Undefined index: draggableviews_setting_view in draggableviews_contextual_links_view_alter() (line 180 of draggableviews.module)

Yep, I have this on all pages that have a view that is not using DraggableViews.

Thank you. One of the warnings is no longer occuring, but I still have:

Notice: Undefined offset: 1 in draggableviews_contextual_links_view_alter() (Zeile 184 von /home/.sites/919/site709/web/2011/sites/all/modules/draggableviews/draggableviews.module).

If you need a dumped variable to find the error, or if I can do anything else, please ask.

Here you go.

You're exactly right. Thank you! Now that I am using DraggableViews how it's supposed to be used (+ your patch) I no longer have warnings, and the sorting works always, not just randomly.

Thank you for the great patch! Committed!

+++ b/draggableviews.moduleundefined
@@ -172,13 +172,14 @@ function draggableviews_contextual_links_view_alter(&$element, $items) {
     // Proceed only if order view is no self.
-    $order_view_display = $view->sort['weight']->options['draggableviews_setting_view'];
-    if ($order_view_display == 'self') {
+    // Also, just to be safe, make sure there is an order display.
+    $order_view_display = $view->sort[$sort_key]->options['draggableviews_setting_view'];
+    if ($order_view_display && $order_view_display == 'self') {
       return;

I this check is not really needed. So I have removed it.

I was getting this error using today's dev, but solved it with the patch in #1410460: Breaking changes with commit b9acb58 or 22a0cd5 — undoubtedly this is a short-lived error but I wanted to report it in case anyone else is having this same problem today!

I don't think this patch is in the latest dev from git for 7.2.x, somehow. I see later commits from the 21st, but not this one. The code in #9 is not there -- but maybe you meant you didn't use it?

Ok, I think this part is important:

    // Proceed only if order view is no self.
    $order_view_display = $view->sort['weight']->options['draggableviews_setting_view'];
    if ($order_view_display == 'self') {
      return;
    }

Notice: Undefined index: weight in draggableviews_contextual_links_view_alter() (line 180

Which come about because "weight" is something else or not defined. I think that part of the patch code needs to be committed, the #9 stuff you omitted, so that $order_view_display gets set correctly.

Subscribe

@carwin, please don't do that ... http://drupal.org/node/1306444

As cschaub says in #11, seems that the patch is not applied in dev. I'm using 2.x-dev from January 30 and still seeing the same error, but now the line is 192.

I try to apply the patch in #6 but i'm getting this error

$git apply -v draggableviews-get_real_weight_sort-1389440-6.patch

Checking patch draggableviews.module...
error: while searching for:
    $view->build($display_id);

    // Proceed only if there is weight sort criteria available.
    if (!isset($view->sort['weight'])) {
      return;
    }

    // Proceed only if order view is no self.
    $order_view_display = $view->sort['weight']->options['draggableviews_setting_view'];
    if ($order_view_display == 'self') {
      return;
    }
    list($order_view_name, $order_view_display_id) = explode(':', $order_view_display);

error: patch failed: draggableviews.module:172
error: draggableviews.module: patch does not apply

I think that the patch should be updated, but i'm not sure how to do that.

Still getting this error, though it does seem to be with less frequency than the last dev version.

Notice: Undefined offset: 1 in draggableviews_contextual_links_view_alter() (line 196 of /path/to/site/sites/all/modules/draggableviews/draggableviews.module).

From what I can tell it's really a random appearance. Sometimes it appears on nodes, sometimes it appears on views. I can't seem to find a real trigger for the cause.

@carwin can you please confirm that patch from #18 solves your case?

@ygerasimov @rooby

Applied patch in #18 cleanly.

Error persisted.

Cleared cache.

Haven't seen it since. Thanks rooby.

----
edit:

Error returned.

Yep, latest dev, same error/notice and same line number.

@roody, I have committed patch #18. I will very appreciate if you can help me with @carwin's problem.

@carwin it would very help if you can guide how exactly to reproduce the error. Could you please enable devel module and apply attached patch. It doesn't fix anything but will dpm() a view that throws error. It will very help if you can trace this view and explain how to create it. Hope in this way we can fix this error. Thank you a lot!

FYI: problem is still there in the 2012-Mar-06 dev release.

@lennartvv, Could you please provide step by step instructions how to reproduce the error?

I got the same error using DraggableViews 7.x-2.x-dev, 2012-Mar-16.
Notice: Undefined offset: 1 in draggableviews_contextual_links_view_alter() (line 182 …

Same.

Please review attached patch. I just have added extra check.

Hi ygerasimov, sorry for my bad english...

I have this problem and patch #31 works, but the problem is that $order_view_display is null, so I could use also the attached patch.

I have created 1 view with 4 display of type "content pane" (2 for order and 2 for display item).
This content pane is added to page with "page manager" and variants of type "panels".

I don't know why my $order_view_display is null

Thanks for your hard work

For the $order_view_display to be empty I would think you would have to have no draggable sort set up for your view.

You are right... now I have set "display sort as" for content pane that list items and notice is gone...

...also without extra check

thanks

edit: draggableviews sort criteria was configured, but I haven't setted the "display sort as" select list... so it was null

now is all ok

The patch #32 is needed when I go to the page that have incorporated the sortable "content pane"

#35 resolves this for me

Alright. I am happy to add this additional check. Committed. Thank you a lot.