By msameer on

filestore is deprecated, I don't like filestore2 as it's using fscache, And I don't know what it's doing ;-)
The upload module is somehow lacking, It can't display the number of downloads AFAIK.
I've spent the last few days working on a file upload/download module which'll allow you to place the files into categories, And you can navigate them just like the article.module. It's saving the files directly to a directory you specify.
"Maybe it's still buggy, I didn't test much".
Guys, Do you think there is a place for another module ? Or shall I forget about it ? Or use it alone? ;-)

Comments

slsmayville’s picture

slsmayville commented

I think it would be great to have a download area. Just my opinion...

budda’s picture

budda
Primary language English
Location Cheshire
commented

Being able to provide members with a downloads section would be great. I've looked at the existing modules a little but wasn't happy.

I'd be interested in checking out another module.

-- www.spamfo.co.uk | www.buddasworld.co.uk

--
Ixis (UK): Drupal support, Drupal hosting.

stelman’s picture

stelman commented

Specifying which directory each files gets uploaded to would be great, rather than just having everything end up in one directory. Would makes managing files a lot easier.

dtabach’s picture

dtabach commented

It would be great if your module could also work with image.module (allowing display of images in galleries) so that we could organize images in different directories too, and control the size of images that can be uploaded.

Durval Tabach

msameer’s picture

msameer commented

You want to upload images too ?

I'm not really sure that this is possible.
I don't like to play with the image module for 2 reasons:
1) The image module is big, I don't want to break it by just inserting rows in its tables.
2) I guess the autor of the image module won't like me :-)

dtabach’s picture

dtabach commented

AFAIK, today you can choose to upload images via upload.module, and display them with the Galleries feature of image.module. As you're proposing an alternative Upload/Download Module, it would be great if it could handle images also.

Durval Tabach

msameer’s picture

msameer commented

To be honest, I'm not sure I'll code a feature like this, Because it can already be done with the image module.

msameer’s picture

msameer commented

Thanks guys for your encouragement!
Here is the current code:
http://uniball.dyndns.org/files/download.tgz

Actually I'm thinking for a way to save the file under a directory named after the taxonomy ID, But I didn't do it yet, But I think allowing the upload to a specified directory is a good feature, Thanks for the suggestion stelman!

ShiftThis’s picture

ShiftThis commented

I really like your module, but I need the ability to upload the files to a non-drupal server and when I change my directory in your settings I get this error"
warning: move_uploaded_file(http://www.othersite.com/shiftthis/files/testfile.txt): failed to open stream: HTTP wrapper does not support writeable connections. in /var/www/html/modules/download.module on line 146.
I do have the external site's directory set to CHMOD 777 so it's fully writable. Any suggestions on how to get this to work?

msameer’s picture

msameer commented

OK
I think no one liked it, Perhaps I should forget the idea.

budda’s picture

budda
Primary language English
Location Cheshire
commented

I've not had time to check it out yet. Will do so during February i hope!!!
So don't give up just yet ;-)

-- www.spamfo.co.uk | www.buddasworld.co.uk

--
Ixis (UK): Drupal support, Drupal hosting.

Will Pate’s picture

Will Pate commented

The idea sounds good, could you provide a demo perhaps? If you don't want to invite the internet, pop me an email (your profile doesn't allow me to email you) with an account where I can give it a test drive. I promise to behave on your server.

I'll be on the road for a few days, but I will give you my feedback.

msameer’s picture

msameer commented

I didn't know that I didn't allow contacts, I did now. Thanks for notifying me!

Actually I don't think that I can setup a demo ATM. My VPS is straggling. I'll try to do it on my home server but it'll be somehow slow.

gordon’s picture

gordon commented

Just out of curiosity what do you not like about fscache?.

Basically I wrote it so that I would have a simple way of storing files on disk, instead of in a database like filestore. But I also need to get around certain issues that such as one that I really hate with the upload module such as files get renamed. Also to help things and to avoid someone uploading the same file 100 times fscache will only store 1 copy of the file.

The reason behind the method that it is stored on disk is mainly for security so that if a malicious file is uploaded such as a copy of a compromised command, then the file will not be able to be found easily, and less likely to be executed by accident.

Also the api for fscache is such that with filestore2 I did not have to worry at all about storing files on disk. I just pass the file from filestore to fscache and everything is handled for me. I did help solve alot of complexity that existed in filestore that is not in filestore2.

I would like know what you don't like about it, so then I maybe able to improve it, or even make it more desirable.
--
Gordon Heydon
Heydon Consulting

--
Gordon Heydon

msameer’s picture

msameer commented

Thanks for your interrest.

What I didn't like about the move from filestore to filestore2 is that I didn't find a way to migrate the old files to filestore2, I also felt that we have a lot of filestore modules and I was afraid to depend on it and then I find it unmaintained oneday. But If I write my own module I'll be maintaining it forever.

What I didn't like about fscache was that I didn't understand the file/directory hierarchy/structure used and It is giving the files strange names so I can't ssh and do "ls" and recognise the files.

I hope I didn't forget anything else!

Actually I'm thinking about switching to the upload module, I wrote a patch to display the number of downloads but i didn't get a response till now.
Actually

gordon’s picture

gordon commented

There has actually been a conversion path from filestore to filestore2 for quite a while. It is actually quite flexible, and allows you to convert back as well. It is quite a non-destructive conversion.

fscache was created so you don't need to know about the underlying directory structure.

as for the upload module, I do fell that it is a faily good module, but I do think it is lacking, such as you found with the download count. Also it doesn't allow for in-line documents such as pdf's or other documents. And also my biggest pet hate of the upload module is that it changes the name of the files if one already exists.
--
Gordon Heydon
Heydon Consulting

--
Gordon Heydon

msameer’s picture

msameer commented

I really don't mind if the file is renamed as long as the new file has a similar name, But completely changing the name is not what I want.

carlmcdade’s picture

carlmcdade commented

I don't like fscache because the upload has to be done via Drupal and then there are a few things that happen.

First large files of 1mb or more slow the browser to a crawl and give no indication of what is happening in the process.

Fscache uses PHP to write and locks the permissions. A simple adjustment to the script to chmod the files and directories would take care of that but it is notoriously never done by developers.

In cases where the file is large 30mb or so I would like to use FTP but Filestore2 uses Fscache and again we are back to reason one.

Fscache does not use file names. A big inconvenience.

Filestore2 does one file at a time. In case of documents and pictures I would like to be able upload multiple files via FTP and have the downloader point to them.

There's more but you get the idea by now. Filestore2 and Fscache are for beginners and users. As a site operator I want something more powerful that gives me control.

Yes, there is room for a better system

---------------------------
www.hivemindz.com (running PHP5)
www.fireorb.org (documentation and hacks)
__________________________
Carl McDade
Information Technology Consult
Team Macromedia

msameer’s picture

msameer commented

I have an idea:
Why don't we start saying what we want from a new download module ?
I personally want:
1) Store the files on the hard drive not in a database
2) Do not scramble the file name.
3) Display the number of downloads per file.

bernardl’s picture

bernardl commented

Personally I think it'd be good to get a nice file gallery module for drupal.

I have been using filebrowser, it is not bad as it basically expose the filesystem so that you can d/l files.

What I don't like, however, is that descriptions can only be added via a file (eg. descript.ion) on the file system. I guess this makes sense, since you are exposing the file system anyways so you would think you have access to it.

What I really want, is a file gallery, which you can upload files, add arbitrary descriptions and then the module will simply give you a listing of the files (display file types with icons etc.) and let you download, edit description, etc.

I have just installed filestore2 - not sure if it can do what I want though...

Any suggestions?

msameer’s picture

msameer commented

I think that what you are asking fr is logical. I like it.

I'll have a look at drupal 4.6 API and perhaps rewrite my module if I find time "I'm really overloaded with work these days".

bomarmonk’s picture

bomarmonk commented

This sounds like the exact solution that I'm looking for... I'm trying filebrowser, but it is very limited (in my experience so far) in allowing different views on directories. For instance, I would like there to be a way to embed the view of a particular directory in a single node and then do the same thing for another directory in another node... I need to create document lists for different departments-- or many different smaller galleries created from my file system.

I would also like to make a way to have users upload only into certain galleries, maybe by combining the new upload functionality with taxonomy and taxonomy access?

I would love to see a new, more flexible module emerge... in the meantime I'll keep experiment with the filbrowser module.

blackfox’s picture

blackfox commented

I'd like to have a module like the file gallery discussed here as well. I'm sad to see, that this thread wasn't discussed for a long time now. I hope someone can help me. An example for a module I want to is here: http://www.kljb-freiburg.de/modules/mydownloads/viewcat.php?cid=9
but this is a xoops-site and I have to realize it with drupal because of other features.

~-blackfox-~

bomarmonk’s picture

bomarmonk commented

I'm using a taxonomy filebrowser, but it's really just a module that makes labeling and lising of files possible through taxonomy (files are actually handled by fscache and filestore2)

I can send you the code for this module if you want to try it out. It is not the solution discussed in this thread, but it's not the officially contributed filebrowser module, either. Let me know.

blackfox’s picture

blackfox commented

thanks for your fast answer - as long as I didn't find what I need I'd like to try every solution possible. I'll use the one who's best for me in the end.

Anyway - if anybody has something else which might be right to me, let me know. Best with a link where I can have a look on the result (for the user)...
~-blackfox-~

msameer’s picture

msameer commented

Looks like people are still interrested ;-)

Here's a couple of small enhancements "They are in the CHANGELOG.txt" file.
http://home.foolab.org/files/download-0.2.tgz

I guess I should try to clean the code, Please don't use it in a production site.

and please help me by listing whatever features you might be interrested in.

bhagman’s picture

bhagman commented

I like where you're going with this, it just needs a lot of finesse. Good work! I think this is the kind of module that would be in line with the Drupal "Keep it lean and clean" concept IMHO.

I can't seem to find where I can edit the file information after I've uploaded the file.

A listing page based on taxonomy would be great (as discussed in this thread).

As a little keen feature as well, it would be nice to have icons associated with file types. (but that can ben done a long time down the road). See: http://harkeydesign.com/node/228

bomarmonk’s picture

bomarmonk commented

Blackfox, your contact form is not enabled. I'd send you the moduke I'm using if I had a way to get it to you.

msameer’s picture

msameer commented

Well, I have his email. I think since he asked you for the module then I'm allowed to give you his email ?

bomarmonk’s picture

bomarmonk commented

I'm also wondering about your module. I'm going to have to give it a try!

Just as a quick aside: I think the ultimate file management module would allow you to associate uploads to a taxonomy and the module would allow you to view a list of files (with names given by the user, or created through a flexinode-like form with flexibility-- combo of server generated time/date and user entered title becomes the file name?) Also, the listed names link directly to the file to download, not a node listing the file. Directories are physical file directories that can be managed through Drupal and linked to taxonomy (an upload in a certain taxonomy will be directed to the proper folder). Anyway, this is my dream file management module... dream... dream... dream (or maybe one day I'll learn a thing or two about php)

Now all we need is to couple this with my dream user permissions system... nice!

(my contact form is enabled, by the way)

blackfox’s picture

blackfox commented

Hi
sorry, I missed to have a look here for a while. Thats because this week my study started and therefore I had to move to the flat in the city where I'm studying. For some time I'm limited with internet-access here... But that isn't the topic here, I know.
My contactform is activated now - so feel free to send me mails.

As already mentioned in an email to m.sameer some wishes I have to this module:
- little icons, optionally replaceable with own ones (see my link abouve)
- automatically display filetype, in an extended version maybe with special icons for some common filetypes
- options to: rate the download, inform admin about dead-download, (not so important: tell a friend)

and one important thing I thought about just at the moment: optionally to upload the file with the browser the admin should be able to upload files via ftp and when creating the download just tell the path to the download-module. That would be great for some bigger files, 'cause when uploading large files the browser gets very slow or even stuck....

~-blackfox-~

msameer’s picture

msameer commented

ATM, I'm putting everything in my CVS http://home.foolab.org/cgi-bin/viewcvs.cgi/projects/drupal/download/

I'll be working on the import FTP uploaded files code. I guess after this I'll ask for a drupal project, Not sure.

The rest of the things can come up later.

I'm not into icons and eye candy to be honest so I guess I'll move it to a lower periority "since it can also be done via the theme".

msameer’s picture

msameer commented

Mass import implemented.

http://home.foolab.org/files/download-0.3.tgz

I'm not sure whether I broke the normal file creation or not "the one done via the create content menu" but i'm soo tired to test.

Ohh, You can import to a subdirectory using the mass import only!

TurboChef’s picture

TurboChef commented

I'm using Drupal 4.6.x on IIS6/Windows 2003, and your download-0.3.tgz file doesn't extract correctly. I'm using WinRAR and it dumps download-0.3 as one file. I can open that up in a text editor, but then I see all files together in it.

I'd really like to try this out (I need a files section on my Intranet very badly). Could you try to repost?

Thanks!

John @ TurboChef

msameer’s picture

msameer commented

WinZip should do it just fine!

PS. It's still beta code with many things missing.

bomarmonk’s picture

bomarmonk commented

I like 7zip even better. It's also free to use!

bomarmonk’s picture

bomarmonk commented

I have disabled all of my other file management modules, except for upload and attachment. When I go to the settings for the download module, I get the following error: warning: mkdir(): No such file or directory in /home/gov/mysite/WWW/drupal/includes/file.inc on line 86.

Also, are the any dependencies or conflicts that we should know about? This sounds good, but I'm not sure how it's supposed to work yet.

msameer’s picture

msameer commented

No conflicts IMHO.
As for the errors, I guess you need to cofigure it 1st.
My local installation is b0rked ATM so I can't really test.

bomarmonk’s picture

bomarmonk commented

Is everyone aware of the work being done here:
http://drupal.org/node/31736

Just thought that this module and that one might work together somehow.

msameer’s picture

msameer commented

I didn't know about it.

But honestly, looks like I don't have time for it so let it rest in peace until I have time again.

bomarmonk’s picture

bomarmonk commented

So now I've got the module running for the most part. I like the mass import feature, but my pdf files are getting corrupted or can't be opened after I upload them. So you are easing off on your work with this module? It seems promising... especially since configurable directories and mass-import are otherwise absent. Thanks for your work so far!

bomarmonk’s picture

bomarmonk commented

I was really hoping I could get this to work, as there about a gazillion files I need to import. I was hopeful, and your module seems to almost work.

Unfortunately, I get the following error: Fatal error: Call to undefined function: mime_content_type() in /home/gov/alpinecounty/WWW/drupal/modules/download/download.module on line 359

destructo’s picture

destructo commented

Anonymous users on my site www.revolutionmusic.net/drupal receive a Not authorized to view this page when attempting to download a file.

Is it possible to allow anonymous users to view and download files? I have the appropriate user permissions set for download files in administration but they still are not able to download.

destructo’s picture

destructo commented

Ok, I reverted to 2.0 and now anonymous users are able to download files, however clicking the Download link in the navigation menu to bring up a list of all downloads brings the following error and a blank drupal theme page:

warning: Invalid argument supplied for foreach() in /home/rev/public_html/drupal/modules/download/download.module on line 435.

Any idea how to fix that puppy?

destructo’s picture

destructo commented

I uploaded the module, activated it and attempted to upload an mp3 but received the following error. Any help?

user error: Table 'rev_drpl1.download' doesn't exist
query: INSERT INTO download (nid, version, homepage, downloads, filetype, filesize, filename, location) VALUES (52, '', '', 0, 'audio/mpeg', 955455, 'hhc - straight edge - minor threat cover with webster death on vocals.mp3', '') in /home/rev/public_html/drupal/includes/database.mysql.inc on line 66.
warning: Cannot modify header information - headers already sent by (output started at /home/rev/public_html/drupal/includes/common.inc:384) in /home/rev/public_html/drupal/includes/common.inc on line 192.

destructo’s picture

destructo commented

ok, i figured it out. u probably already know that you have to import the database file into phpmyadmin ;)

msameer’s picture

msameer commented

Sorry for the late reply, I was attending africa source 2.

Looks like people are still interrested. I'll try to find time to complete the module then. Anyone volunteering to help ??

brashquido’s picture

brashquido commented

Have been looking for a good downloads module for Drupal, and this one looks like it's best suited for my needs to date.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

+1 for this module

I'm interested in this module, too.
How about creating a Drupal module project at Drupal.org so we could make this thing work together?

Daniel F. Kudwien
unleashed mind

Daniel 'sun' Kudwien
makers99

bomarmonk’s picture

bomarmonk commented

I have posted a link to the better upload module (above), but I also thought I would mention disknode as another related module. Maybe some combination of the download module mentioned here and the views module would do everything... just speculating.

msameer’s picture

msameer commented

Unfortunately, Looks like I don't have much time for it.

I have some ideas about multiple upload "FTP, Web, Local directory" and download "FTP/HTTP" backends but I've no time to do it.

I can still contribute to the project if someone is welling to take the lead or I'll have to take the lead if there's much interest until someone else poppes up and takes the lead.

bomarmonk’s picture

bomarmonk commented

dopry, a drupal user and developer, is working on a new file API/system for drupal. He has already added his initial work to CVS and wants this to be something new in Drupal 4.8 core. It might make other file management, upload/download modules easier to create or at least more efficient and more powerful. You might want to check out his work and the better upload module (in a very early state according to CVS messages). The developer of better upload may not have time to work on the module further, so if anyone with PHP savy is interested in supporting it, you might contact the developer, Ber Kessels. He says this about some of the work he has started, like the new upload module: "Maybe someone with more time and plans can take them over, maybe not."

In the end, it would be great to see the features developed in this "downloads module" find their way into a stable, full featured file management module, or a collection of independent modules that use the new API and work together. Anyway, thanks for the work so far, and if it is ever finished, I'm sure it will greatly benefit Drupal.