The best example is workbench -- The primary workbench page doesn't display any tabs because there is no "default" selected tab, so there's no current item to be displayed as block.

I'm not sure if it's valid to not have any default secondary tab -- i.e. is the bug in workbench? But there's a number of modules that have this issue so it might be worth fixing in Rubik. Not sure what the best way to implement such a fix would be.

CommentFileSizeAuthor
#7 1389660-rubik-secondary-tab-fix-2.patch548 bytesacbramley
#6 1389660-rubik-secondary-tab-fix-2.patch546 bytesacbramley
#3 1389660-rubik-secondary-tab-fix.patch293 bytesacbramley
#1 secondary-tabs.png11.03 KBfearlsgroove
#1 seven-secondary-tabs.png16.13 KBfearlsgroove

Comments

fearlsgroove’s picture

fearlsgroove commented
StatusFileSize
new seven-secondary-tabs.png16.13 KB
new secondary-tabs.png11.03 KB

A few quick screenshots demonstrating the issue
secondary-tabs.png

seven-secondary-tabs.png

acbramley’s picture

acbramley commented

+1 getting this exact issue too using Rubik 7.x-4.0-beta8 and Workbench 7.x-1.1+9-dev

acbramley’s picture

acbramley commented
Status: Active » Needs review
StatusFileSize
new 1389660-rubik-secondary-tab-fix.patch293 bytes

This 1 line patch fixes this issue

acbramley’s picture

acbramley commented

Hmmm, needs some work as when on a secondary page that's not the first child you see both secondary links

acbramley’s picture

acbramley commented
Status: Needs review » Needs work
acbramley’s picture

acbramley commented
Status: Needs work » Needs review
StatusFileSize
new 1389660-rubik-secondary-tab-fix-2.patch546 bytes

This adds a small (sort of hacky) bit a jquery that will display the first secondary tab as a block if there's no active one

acbramley’s picture

acbramley commented
StatusFileSize
new 1389660-rubik-secondary-tab-fix-2.patch548 bytes

Woops, this one is working

codi’s picture

codi commented
Status: Needs review » Reviewed & tested by the community

Tested the patch in #7 against 7.x-4.x-dev and it works for me. Tested it with workbench as well as a couple other modules that provide secondary tasks.

pvhee’s picture

pvhee commented

Can confirm #7 is working perfectly.

haydeniv’s picture

haydeniv commented
Status: Reviewed & tested by the community » Fixed

Committed: d0ca028
Thanks!

acbramley’s picture

acbramley commented

Woo thanks a lot! Good to have things finally moving along :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.