Port current D6 release to D7

Cross-referencing #1390182: Add change notice and update simplenews_mail() documentation

The current 7.x version is not supported anymore. The people who did the port to D7 have (I think) abondened it... I will personally be picking up a D7 version in the near future, but it will probably not be compatible with the current 7.x release. Keep that in mind.
Untill then there is no working release for Simplenews Statistics in D7. Sorry...

@weseze: Feel free to ping me if you need anything in regard to Simplenews 7.x-1.x.

Patch attached to make it work with current D7 version of simplenews. Using it in production.

Patch looks good to me.

We simply need to port the current D6 version to D7, because the 2 versions are completely out of sync. D6 has more features, views integration, ... So we need to (or more to the point: I need to ;)) shift towards developing for D7 and backporting to D6.

This error message in logs excepted, #6 seems ok here:
PDOException : SQLSTATE[23000]: Integrity constraint violation: 1062 Duplicate entry '1330621183' for key 'PRIMARY': UPDATE {simplenews_statistics_opens} SET opens=:db_update_placeholder_0, timestamp=:db_update_placeholder_1 WHERE (nid = :db_condition_placeholder_0) AND (email = :db_condition_placeholder_1) ; Array ( [:db_update_placeholder_0] => 5 [:db_update_placeholder_1] => 1330621183 [:db_condition_placeholder_0] => 20 [:db_condition_placeholder_1] => mail@example.com ) in simplenews_statistics_view() (line 104 in /modules/simplenews_statistics/simplenews_statistics.module).

this patch doesn't fix the pdo error

This issue has a better title. It is a duplicate of http://drupal.org/node/1502736. Continuing development on this issue.

The attached patch is based off of a fresh 6.x-3.x.-dev release as of April 20, 2012. Any changes to 6.x-3.x-dev must still be ported to this D7. The patch though defines the changes between the last 7.x-1.x-dev release.

Disregard the last patch. This one incorporates all 6.x-3.x-dev updates from the last several weeks. It is built on top of patch 14 though, sorry for that error.

so do we not use patch 14 before we apply 15?
do the patches apply to the D7 dev version?

Downloaded d7 and applied patches:

patch 15:
git apply simplenews-statistic-upgrade-1390184-16.patch
fatal: corrupt patch at line 1112

patch 14:
simplenews_statistics$ git apply simplenews-statistic-upgrade-1390184-14.patch
simplenews-statistic-upgrade-1390184-14.patch:1060: trailing whitespace.

simplenews-statistic-upgrade-1390184-14.patch:1077: trailing whitespace.
db_update('simplenews_statistics')
simplenews-statistic-upgrade-1390184-14.patch:1078: trailing whitespace.
->fields(array(
simplenews-statistic-upgrade-1390184-14.patch:1079: trailing whitespace.
'send' => ((int) $result->send) + 1,
simplenews-statistic-upgrade-1390184-14.patch:1080: trailing whitespace.
))
error: patch failed: LICENSE.txt:1
error: LICENSE.txt: patch does not apply
error: patch failed: simplenews_statistics.info:1
error: simplenews_statistics.info: patch does not apply

I had made a mistake in how I committed the patches. Unfortunately the port to D7 is almost done, but the D6 version continues to evolve and it is difficult to coordinate.

Apply the patches in this order
simplenews-statistic-upgrade-1390184-14.patch
1390184-simplenews-statistic-upgrade-16.patch

Please give me feedback if the patches work - I will contact the maintainer again this week.

I can not apply these patches... getting lots of errors. Could you provide your entire 7.x version? You can post it here or mail it to me.

D6 version will not "evolve" anymore, the views integration was the last step. From now on only bugfixes will make it in to D6 version.

Certainly, this does get annoying that EGIT does not properly create and apply patches (at least I cannot get it to function 100%). Time to admit defeat and switch to TortoiseGIT or to a different GIT interface :)

ZIP attached.

If you're on windows, check out msysgit. (Check out this video on Build a Module.com... Or smart git for Mac here's a video for smart git)

Here's a patch that updates the current 7.x release in Git to the module posted in #19.

thanks bjlewis2!

finally had a few minutes to check the patch... it is only a partial patch of the module root directory. All sub-directories and moved files are missing.

Oops, I'll get a new patch out later today.

Here's the updated patch. When I tested it, git said there were trailing white spaces, but I didn't see them, so if you know how to fix them, please do! (Or better yet, if I've made a common mistake, let me know so that I can avoid it in the future)

patch looks great to me bjlewis2 - thanks again!

Weseze, can you please commit? In addition to a dev site, I already have the module + patch installed on 2 prod sites and patch works fine, looking into a 3rd.

Lets get it out the door so I can start on some minor issues and updates for D7 and D6 :).

I'll take a look at it today and try and start up the d7 branch again.

OK I have reviewed the patch and comitted it to the D7 branch. There are still lots of things todo but I belive we have a solid foundation to work from here. Hopefully this wil speed up D7 development!
Todo's for the D7:

• README.txt
• Track mailto links setting (see latest D6 version)
• D6 3.x to D7 1.x upgrade path (if possible)
• URL shortener (problem with dependencies here...)
• Delete custom built overview pages in favor of views (see latest D6 release)

Would be great if someone (or multiple people) could step forward and create seperate issues for these!

Thanks a lot for the commit. I will now look at the issue queue - and create separate issues for each of the points you discussed. I plan to reply once more (hopefully today) when I have download the committed version and tested that it is ok.

I have tested on 3 websites. From my end, this should be closed.

Marking this as fixed. The port is done, all other issues can be fixed in seperate issues.