[D8] Improved Multi Select

welcome

You are not working correctly with branches in git! The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 6.x branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• ./improved_multi_select.install: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function gbnews_uninstall() {
  

• Remove all old CVS $Id tags, they are not needed anymore.
  

  improved_multi_select.info:1:; $Id: $
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See http://ventral.org/pareview/httpgitdrupalorgsandboxdmitrii1379392git-6x.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

There are still files other than README.txt in the master branch, make sure to remove them. See also step 5 in http://drupal.org/node/1127732
Review of the 7.0 branch:

• README.txt is missing, see the guidelines for in-project documentation.
• Remove "version" from the info file, it will be added by drupal.org packaging automatically.
• improved_multi_select.install in improved_multi_select.info: It's only necessary to declare files[] if they declare a class or interface.
• improved_multi_select.module in improved_multi_select.info: It's only necessary to declare files[] if they declare a class or interface.
• improved_multi_select.css in improved_multi_select.info: It's only necessary to declare files[] if they declare a class or interface.
• improved_multi_select.js in improved_multi_select.info: It's only necessary to declare files[] if they declare a class or interface.
• ./improved_multi_select.install: all functions should be prefixed with your module/theme name to avoid name clashes. See http://drupal.org/node/318#naming
  

  function gbnews_uninstall() {
  

• Remove all old CVS $Id tags, they are not needed anymore.
  

  improved_multi_select.info:1:; $Id: $
  

• Drupal Code Sniffer has found some code style issues (please check the Drupal coding standards). See http://ventral.org/pareview/httpgitdrupalorgsandboxdmitrii1379392git-70.

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

Hi dmitrii,
module works very well, your idea is really interesting.

I made a manual review, I drop down something I noticed about your module:

1) The "Replace multi-select lists on listed pages" textarea seems not support wildcards. You should use drupal_match_path function to parse the textarea to support wildcards (Example: node/*/edit)
2) You should provide a description for "Replace multi-select lists on listed pages" textarea to help users to use it.
3) On master git branch there is an old Drupal 7 version of the module. You should switch to 7.x-1.x branch and clean up master branch.

Good job with this module!

Closing due to lack of activity. Feel free to reopen if you are still working on this application.

Thank you for your contribution! I added the PAReview checklist, and reviewers will soon check the code and report here what need to be changed.

If you still haven't done it, please check what reported from the PAReview checklist, and change what is suggested to be changed. There could be some false positives; be careful of not changing code that should not be.

Thank you for your contribution! I am going to update your account.

These are some recommended readings to help with excellent maintainership:

• Dries' post on Responsible maintainers
• Best practices for creating and maintaining projects
• Maintaining a drupal.org project with Git
• Commit messages - providing history and credit
• Release naming conventions.
• Helping maintainers in the issue queues

You can find more contributors chatting on the IRC #drupal-contribute channel. So, come hang out and stay involved.
Thank you, also, for your patience with the review process.
Anyone is welcome to participate in the review process. Please consider reviewing other projects that are pending review. I encourage you to learn more about that process and join the group of reviewers.

I thank all the dedicated reviewers as well.