Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
Seven theme
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
31 Dec 2011 at 15:18 UTC
Updated:
29 Jul 2014 at 20:17 UTC
IF condition always evaluate to true :(
| Comment | File | Size | Author |
|---|---|---|---|
| seven.patch | 826 bytes | droplet |
Comments
Comment #1
tamanna-freelancer commentedI have tested this patch and it works fine.
Comment #2
xjmThanks for the patch! Kinda not sure about the form of this fix, though. I don't think it's backportable, either. See:
I think we need more review on the approach here, at least.
Comment #3
David_Rothstein commentedSo is this issue actually a duplicate? It seems like the first part of the patch is being covered in #997408: $tabs is always set and the second part in #953034: [meta] Themes improperly check renderable arrays when determining visibility...
This will break if you have other blocks in the 'Help' region, or if you're using something other than the Block module to manage your page regions.
Comment #4
bleen commentedfixing title ...
Comment #5
xjmClosing as duplicate of #1158090: Separate usage of hide(), render(), and other template features from print statements to enable non-developers to create themes .