Amazing module, thank for the D7 version!
I believe Taxonomy and Users "nodes" are not being checked, and they are just like any other node, can contain links. Can you expend the functionality to include them?
| Comment | File | Size | Author |
|---|---|---|---|
| #28 | 1390872_28.patch | 4.04 KB | shubhangi1995 |
| #19 | taxonomy-integration-1390872-18.patch | 17.82 KB | samvel |
| #15 | integration-independent-modules-1390872-15.patch | 3.85 KB | samvel |
Comments
Comment #1
hass commentedShare a patch, please.
Comment #2
hass commentedComment #3
shaisamuel commentedI wish I new. Just doing my first steps.
Comment #4
edu2004eu commentedSubscribe.
Comment #5
hass commented#1067120: Missing hook_taxonomy_term_view() or hook_entity_view() when viewing a term
Comment #6
neurojavi commentedIssue #1067120: Missing hook_taxonomy_term_view() or hook_entity_view() when viewing a term is solved for 7.x, the patch is included in 7.17.
Does this module need some change to work with terms now that the include the standard entity hooks or it just works now?
Thanks for this great module!
Comment #7
hass commentedNope, this may need a lot of work.
Comment #8
samvel commentedHi guys,
In my work i need integration with taxonomy, bean and field_collection.
I created big patch for taxonomy part, please review it. I suggest exclude each functional part in different submodules(in future for existing parts too). Check how i did in my patch. I made everything as well as in the main module.
To use not forget enable "linkchecker_taxonomy" module.
Comment #10
samvel commentedAgain...
Comment #11
hass commentedLooks really good to me, but can you add some test, please?
Comment #12
samvel commentedI can, but then later, because this work will be only in free time
Comment #13
hass commentedWell, are we not all working for free? At least me.
We should make sure that this will not break some days without getting noticed.
Comment #14
samvel commentedYes of cource, i meant that i needed this functional in my work.
Yes, of course. We can wait other reviews and in any case will be better also write tests. But i can't write it right now.
Comment #15
samvel commentedSo, i split previous patch. Was appended few hooks to get independent of modules.
hass, please review this patch
After i will append patches for taxonomy and beans modules.
Comment #16
samvel commentedComment #17
samvel commentedPatch for taxonomy, again(previous patch WRONG).
Should be applied after integration-independent-modules-1390872-15.patch will be implemented!
Comment #18
samvel commentedAppended patch for bean integration.
Small fixes in taxonomy integration.
Not forget please, that these patches should be implemented after integration-independent-modules-1390872-15.patch
Comment #19
samvel commentedSmall fixes in delete function.
Not forget please, that these patches should be implemented after integration-independent-modules-1390872-15.patch
Comment #20
hass commentedCould we split this into seperate issues, please?
Comment #21
samvel commentedHi Alexander,
Why you showed me old patches?
Should i move taxonomy and beans in other tasks? And in this task we keep "integration-independent-modules" ?
Comment #22
hass commentedLet's make this the taxonomy case here and move bean to an extra case. I only hided outdated patches. See issue summary.
Comment #23
samvel commentedfollow #2127731: Bean compatibility
Comment #24
hass commentedHave you seen #2060243: Split linkchecker_scan_nodetypes as content type specific? I plan to move setting to conent type settings. Maybe we can add the vertical tab to taxonomy settings page, too.
Comment #25
samvel commentedOk, i will prepare new patch, for taxonomy only (seems good idea split settings)
Comment #26
sirchaox1224 commentedApplying #15 and then #19 appears to be working beautifully for taxonomy integration. Thanks!
Comment #27
hass commented#15 has a typo in the API name,
linkcheker_main_table.Comment #28
shubhangi1995Hi @hass
(/) corrected the typo
(/) replaced module_invoke_all with Drupal::moduleHandler()->invokeAll
(/) replaced depricated l() with Link::fromTextAndUrl and Url::fromUri
Comment #29
shubhangi1995Comment #30
hass commentedPlease do not waste your time on new features until the basic port is completed.
Comment #31
pnagornyak commentedThis already fixed by new logic of link extraction for D8.