Posted by FiNeX on January 2, 2012 at 1:20pm
2 followers
| Project: | Google Analytics |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | closed (won't fix) |
Issue Summary
Hi! I've created a small patch for Google Analytics 6.x-3.3 which adds the possibility to track the position on the Google SERP thanks to this article from SEOmoz:
http://www.seomoz.org/blog/tracking-organic-ranking-in-google-analytics-...
The patch is quite simple: it adds a checkbox on the settings page for enabling/disabling the feature, if enabled the custom variable is set.
Comments
#1
Patch for -dev version.
#2
We already have custom variables support in the module and this patch create collisions. If you are missing anything it should be done with a custom token. I think this is the cleanest way we can go. I have no problem with adding more useful tokens to ga. Please see the code.
Then users who need this data can configure the same with a token. It's not one checkbox, but a documentation page on d.o can describe how to get this configured and we are still clean.
#3
Aside. every new feature goes in D7 first, than may be backported.
#4
You're right!!!! A custom token could be a cleaner solution, would you suggest to create an extra module which adds the token or manage it directly by Google Analitycs module?
Thanks!
#5
I'm fine with integrating this in the module itself. It's very ga specific... We may need to write a documentation page for this just like the referenced link.
Yesterday I have not understood on code review why there are two regex... Is this really nessesary? No idea how the url looks like...
#6
Sounds like we don't need this any longer, isn't it? See http://analytics.blogspot.com/2012/01/update-to-search-engine-optimizati...
#7
4 months no feedback, closing.
#8
@hass: I agree... moreover it looks like "cd" parameter could be deprecated soon.