When using this otherwise nice module, I find that if the apartment number is left blank, it becomes a Zero ("0") after saving and returning to the node.

Those with simple street addresses are now at "123 Main Street #0"

I imagine that this is a simple fix to those skilled in the area?

Comments

rconstantine’s picture

rconstantine commented
Assigned: Unassigned » rconstantine

Opps. I may have set the database to have a non-null default value. I'll change that.

rconstantine’s picture

rconstantine commented

For a quick fix, you can change the database column to allow NULL values and to set NULL as the default value.

cayenne’s picture

cayenne commented

Thanks, I'll try that workaround.

Say, can I set the default state the same way?

rconstantine’s picture

rconstantine commented

You can't. This would work only if the field could be left blank. I hadn't thought about allowing the admin to set defaults for each field, but that's an interesting idea. And it would be pretty simple. If I have time during my next round of bug fixes, I'll add that in.

But bug fixes come first, you know.

cayenne’s picture

cayenne commented

Hmmm. Database column already WAS able to set null, with default as null as well. Waaaah.
As long as one is looking at it, perhaps we might allow alpha in the field. I have friends in apartment 19-A, for example.

rconstantine’s picture

rconstantine commented

I'll do that. I really appreciate the feedback. Look for an update a week from yesterday.

cayenne’s picture

cayenne commented
Title: Blank Apartment Number becomes Zero » Thank you
Priority: Normal » Minor

I have commented out the apartment code, just letting folks add the apt number to their street address. You might consider making the number a configuration option rather than an "always in".

Not only does this reduce screen real estate usage, but it creates more flexibility in letting people describe their address the way the POST OFFICE wants to see it.

I'd suggest cutting the element out entirely, but that may strand existing users. In any case, thank you for the module!

rconstantine’s picture

rconstantine commented

I don't think you're using the dev version are you? Anyway, I don't get the #0 showing up if I leave the field blank. Can you update to the latest and let me know if it's still there? Also, another update should be coming in the next day or two to fully fix the issues with Canadian addresses and establish a pattern for future support of other countries.

rconstantine’s picture

rconstantine commented

Ah ha! I spoke too soon. It turns out that if the required field is checked then the problem exhibits itself. Thanks. I'll fix that too.

michelle’s picture

michelle
she/her
Primary language English
Location Wisconsin, USA
commented
Title: Thank you » Blank Apartment Number becomes Zero

Just changed the title back because "thank you" doesn't say much about the issue for people looking at the queue.

Michelle

rconstantine’s picture

rconstantine commented

I think I fixed it. Look for a new dev release later today.

rconstantine’s picture

rconstantine commented
Status: Active » Fixed

Forgot to change status...

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)