We should add some kind of validation for the meta tags. This seems to be a pretty common error that people don't know exactly what to put into the field.

CommentFileSizeAuthor
#5 1391860-5.site_verify.add-validation-form-meta-tags.patch1.75 KBjoachim
#2 add-validation-form-meta-tags-1391860-2.patch1.72 KBroam2345

Comments

mgifford’s picture

mgifford
he/him
Primary language English
commented

Duplicate of #1435902: Verification META tag appeard on page but marked as original.

roam2345’s picture

roam2345 commented
StatusFileSize
new add-validation-form-meta-tags-1391860-2.patch1.72 KB

here is a patch to do this.

roam2345’s picture

roam2345 commented
Status: Active » Needs review
roam2345’s picture

roam2345 commented

cross linking this as i need this patch and it conflicts with another issue #696436: Use File API and file_transfer()

joachim’s picture

joachim commented
Issue summary: View changes
Status: Needs review » Needs work
Issue tags: -Security improvements
StatusFileSize
new 1391860-5.site_verify.add-validation-form-meta-tags.patch1.75 KB

Is this an actual PHP operator I've never heard of, or a typo:

  if ($metas->length <! 0) {
    return FALSE;
  }

This is why I like comments even for small statements like this, eg, // Validation fails if yadayada.

Here's an updated patch with comment and UI string fixes.

elc’s picture

elc commented
Status: Needs work » Closed (outdated)

This was addressed as part of SA-CONTRIB-2017-051 in 7.x-1.2.