Just saw that this module is dealing with lots of strings around this variable and I'm sure that this variable as type boolean will do a great job. A patch for that is attached together with setting the default during installation to FALSE.

CommentFileSizeAuthor
#2 make_variable-1391926-2.patch4.53 KBjurgenhaas
aes.patch3.37 KBjurgenhaas

Comments

dpovshed’s picture

dpovshed commented
Issue summary: View changes
Status: Active » Needs work

Totally agree about your idea, but I have feeling the code fragments like

if (variable_get("aes_convert", FALSE)) {

will compromise users who have currently stored aes_convert as a string, just because string is TRUE when casted to bool.

So if we need change to be applied would be nice to:
- add update_hook_N;
- reformat according to coding standard.

jurgenhaas’s picture

jurgenhaas
he/him
Primary language German
Location Gottmadingen
commented
Status: Needs work » Needs review
StatusFileSize
new make_variable-1391926-2.patch4.53 KB

Agreed, the rewritten and extended patch is attached.

dpovshed’s picture

dpovshed commented
Status: Needs review » Fixed

Revieved, tested and committed to dev without any changes. Thanks Jürgen!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit a470d28 on 7.x-1.x, 8.x-2.x authored by jurgenhaas, committed by dpovshed: 
    Issue #1391926 by jurgenhaas: Make variable aes_convert to a real...