The Demandbase for Webform module exists to simplify usage of the "Demandbase for Web Forms" product. This module allows content managers to populate the components of a Webform (3.x) with values from Demandbase. Much more information detailed in sandbox.

Git Clone Info

git clone --branch master [your-user]@git.drupal.org:sandbox/bartclarkson/1391874.git demandbase_for_webform

Thanks.

CommentFileSizeAuthor
#9 drupalcs-result.txt1.36 KBklausi

Comments

patrickd’s picture

patrickd commented
Title: Demandbase for Webform; Request for Full Project Access » Demandbase for Webform
Status: Needs review » Needs work

welcome

It appears you are working in the "master" branch in git. You should really be working in a version specific branch. The most direct documentation on this is Moving from a master branch to a version branch. For additional resources please see the documentation about release naming conventions and creating a branch in git.
Review of the master branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Go and review some other project applications, so we can get back to yours sooner.

bartclarkson’s picture

bartclarkson commented

Thanks, Patrick. I'll clear these.

The README.txt error is odd. It's in there, and the diagnostic (http://ventral.org/pareview/httpgitdrupalorgsandboxbartclarkson1391874git) mentions:

FILE: .../modules/pareview_temp/test_candidate/demandbase_for_webform/README.txt

patrickd’s picture

patrickd commented

It's not, because you pushed your module in a folder, but your module files should be in the root of git ;-)

bartclarkson’s picture

bartclarkson commented

Yeah, that would do it.

Thanks, Patrick. I took another whack at it.

I'm going to have to dig a little, meanwhile, because it looks like my local /coder module isn't catching the .txt and .js conventions ventral is validating. I may be missing something. I'm also not catching invalid commenting.

patrickd’s picture

patrickd commented

your welcome

the website is not only using coder, its using Drupal Code Sniffer
if you want to use it localy, here's a good article about it

if you got any questions on that please ask!

bartclarkson’s picture

bartclarkson commented

Great. I'm afraid I'm going to have to abuse Ventral with 2-3 more reviews. I can't get on the Eclipse Sniffing bandwagon until next week sometime.

I ran branch 7.x-1.0 here:

http://ventral.org/pareview/httpgitdrupalorgsandboxbartclarkson1391874gi...

More work to do, but I now have a workflow I understand, thanks to your efforts.

I'll comment again when I clear the diagnostic. Thanks for being so responsive.

bartclarkson’s picture

bartclarkson commented

All righty, Patrick. I have cleared all the code styling issues. Also removed everything by README.txt from the MASTER.

http://ventral.org/pareview/httpgitdrupalorgsandboxbartclarkson1391874gi...

Thanks.

patrickd’s picture

patrickd commented
Status: Needs work » Needs review

Don't forget to switch back to needs review after you think you've fixed everything.
Now you have to wait for in-depth reviews, as the queue has become quite full over the holidays this will take some time.

Please consider to help us reviewing other project applications, you'll definitely learn something ;-)
See http://drupal.org/node/894256 for more information.

regards

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work
StatusFileSize
new drupalcs-result.txt1.36 KB

The following git branches do not match the release branch pattern, you should remove/rename them. See http://drupal.org/node/1015226

* 7.x-1.0
  remotes/origin/7.x-1.0

Review of the 7.x-1.0 branch:

This automated report was generated with PAReview.sh, your friendly project application review script. You can also use the online version to check your project. Get a review bonus and we will come back to your application sooner.

manual review:

  • demandbase_for_webform.info: you should depend on the webform module, no?
  • demandbase_for_webform_install(): empty function, so remove it. Same for hook_uninstall().
  • demandbase_for_webform.install: don't load the include file globally, do it in the function where you need it.
  • "'access arguments' => array('access administration pages'),": this permission is too generic, create your own.
  • "// $result = !$result;.": Remove all debug statements or old commented out code.
bartclarkson’s picture

bartclarkson commented
Status: Needs work » Needs review

Thanks, klausi!

I have made the requested code changes. I'm pretty sure I corrected the branch + tagging problem. Interesting stuff.

bartclarkson’s picture

bartclarkson commented

I've added functionality to the -dev branch that I'm going to hold onto for a 1.1 release.

ishanmahajan’s picture

ishanmahajan commented
Status: Needs review » Needs work

Hi Bart,

It's fantastic to have demandbase integration with webforms!

I've filed a bug which I found while testing the module:
http://drupal.org/node/1513142

Regards,
Ishan

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs work » Closed (won't fix)

Closing due to lack of activity. Feel free to reopen if you are still working on this application.