It would be handy to have a wrapper (.sharethis-wrapper) around the span images. If it is preferred for the mod to not have a wrapper could someone point out to me where in the module the code could be added to achieve this and I'll add it myself.

Many thanks

CommentFileSizeAuthor
#8 sharethis-1392050.patch467 bytesneochief
#5 sharethis-wrapper.png12.38 KBkingfisher64

Comments

jvalencia’s picture

jvalencia commented

sharethis_get_button_HTML function in sharethis.module

robloach’s picture

robloach
he/him
commented
Status: Active » Needs review

Doesn't it usually get wrapped by ".sharethis-buttons"? Where does it not get that class?

robloach’s picture

robloach
he/him
commented
Status: Needs review » Postponed (maintainer needs more info)
kingfisher64’s picture

kingfisher64 commented
StatusFileSize
new sharethis-wrapper.png12.38 KB

When placed in the block in omega theme there's no wrapper directly around the span icons. In the screenshot attached there's .content however I was hoping for something more specific to the module to reference.

Quarath’s picture

Quarath commented

The most simple solution:
in \modules\sharethis\sharethis.module
line 369

-  return $st_spans . $st_js;
+  return '<div class="sharethis-wrapper">' . $st_spans . $st_js . '</div>';
bcobin’s picture

bcobin commented

@Quarath,

Thank you for this! It should definitely go into the module... you're a lifesaver!

neochief’s picture

neochief commented
Status: Postponed (maintainer needs more info) » Needs review
StatusFileSize
new sharethis-1392050.patch467 bytes

Somebody, please review the patch.

robloach’s picture

robloach
he/him
commented

Looks pretty good to me! Are there any outside wrappers that we implement? Like for the block?

robloach’s picture

robloach
he/him
commented
Version: 7.x-2.2 » 7.x-2.x-dev
kingfisher64’s picture

kingfisher64 commented

Perfect.

I don't think we need an outside wrapper. There's the block and now the sharethis-wrapper. For me that's good enough. :)

neochief’s picture

neochief commented
Status: Needs review » Reviewed & tested by the community
robloach’s picture

robloach
he/him
commented
Status: Reviewed & tested by the community » Fixed

Thanks a lot! Committed: http://drupalcode.org/project/sharethis.git/commit/c3d6d08

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.