So we updated the server to php 5.3 and dibs stopped working. Seems there is a problem using module_invoke using referenced arguments. This is due to the use of call_user_func_array in module.inc from core.

Since this effectivly renders any custom hook_dibsapi() useless on php-5.3 systems I implemented a fix that bypasses module_invoke, but retains the functionality.

Patch included.

CommentFileSizeAuthor
#2 php-5.3-reference-1392678-2.patch687 bytesstixes
php-5.3-reference.patch626 bytesstixes

Comments

stixes’s picture

stixes commented
Assigned: stixes » Unassigned
stixes’s picture

stixes commented
StatusFileSize
new php-5.3-reference-1392678-2.patch687 bytes

Was missing function definition in the patch. Could still use a review, and is still very much an issue with php 5.3 installations.

mikl’s picture

mikl
Location Møn
commented
Status: Needs review » Fixed

This commit should hopefully fix all the pass by reference issues: http://drupalcode.org/project/dibs.git/commitdiff/6606c208d9e50caafb7d88...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.