There may be times when you don't want the module to send mails but you do want it to respond to requests to disable mails. There should be a setting on the configuration page to disable the sending of mails from this module.

CommentFileSizeAuthor
#3 1392906-no-mail-3.patch5.62 KBMorinLuc0

Comments

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Active » Postponed (maintainer needs more info)

Patches welcome :)

kscheirer’s picture

kscheirer
Primary language English
Location Vallejo
commented
Status: Postponed (maintainer needs more info) » Active
MorinLuc0’s picture

MorinLuc0 commented
Issue summary: View changes
StatusFileSize
new 1392906-no-mail-3.patch5.62 KB

Added the feature to disable the email sending part of the notify comments.
Possible the next step would be some sort of block or page to display the list of notifications the user has, possibly expose the data to views ?

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review

The patch looks good to me. Could you try adding a test for the behavior to ensure it keeps working?