Opened a new item for the 7.x branch. I have the exact same issue as noted for the 6.x branch of this module where an incompatibility with the CAS module occurs. I am attaching a patch for this issue.

This patch is specific for CAS, but you can see I had to skip on the custom validation routine.
Likewise, I had the error with the $form validate element not being initialized same as was for the 6.x branch issue.

CommentFileSizeAuthor
#10 noreqnewpass-cas_compat-1392992-10.patch737 bytesdgeo
#9 noreqnewpass_cas_comp.patch737 bytesmallezie
#8 noreqnewpass-cas_compat-1392992-8.patch1.58 KBdgeo
#6 noreqnewpass-cas_compat-1392992-6.patch1.58 KBdgeo
#4 noreqnewpass-cas_compat-1392992-4.patch1.58 KBdgeo
#2 noreqnewpass_cas.patch1.75 KBdgeo
incompatible_with_cas-1065764-1.patch1.27 KB_randy

Comments

katrialesser’s picture

katrialesser commented

Is this module still not compatible with CAS? I just installed it and now CAS login doesn't work, there are warnings about the noreqnewpass module.

Just wondering if there is a solution yet?

dgeo’s picture

dgeo commented
StatusFileSize
new noreqnewpass_cas.patch1.75 KB

Here is a small patch, combining #239628: Error on first login (higher weight for this module) and the smallest solution that works for me™.

wardv’s picture

wardv commented

I can confirm that CAS login is broken if 'Disable Request new password link' is enabled. When clicking 'login', the user is not redirected to the CAS login page anymore.

This is on Drupal 7.22, with the No request New Password 7.x-1.2 and CAS 7.x-1.2.

I can also confirm that the patch from #2 fixes the problem.

Can you please fix this in the stable version of this plugin?

dgeo’s picture

dgeo commented
Issue summary: View changes
StatusFileSize
new noreqnewpass-cas_compat-1392992-4.patch1.58 KB
dgeo’s picture

dgeo commented
Status: Active » Needs review
dgeo’s picture

dgeo commented
StatusFileSize
new noreqnewpass-cas_compat-1392992-6.patch1.58 KB

for review and automatic testing…

dgeo’s picture

dgeo commented
Version: 7.x-1.2 » 7.x-1.x-dev
dgeo’s picture

dgeo commented
StatusFileSize
new noreqnewpass-cas_compat-1392992-8.patch1.58 KB
mallezie’s picture

mallezie
Primary language Dutch
Location Loenhout
commented
StatusFileSize
new noreqnewpass_cas_comp.patch737 bytes

I also stumbled on this issue. The patch does indeed work for compatibility with the cas module.
Can't we add a check to see if $form['#validate'] is set? That way the fix would also work with other modules which override the login-validation.

Patch attached.

dgeo’s picture

dgeo commented
Assigned: Unassigned » dgeo
StatusFileSize
new noreqnewpass-cas_compat-1392992-10.patch737 bytes

Renaming patch (how to trigger automatic testing ?

Is there any way to get it included before third millenium ?

I'd like to help here… but how ?

Last patch seems minimalistic enough, reported working and tested, I just renamed it to fullfill guidelines…

dgeo’s picture

dgeo commented
neslee canil pinto’s picture

neslee canil pinto
he/him
Primary language English
commented
Status: Needs review » Closed (works as designed)