Default node for a PDF

Can you re-roll this without #1356304: Webform query broken when no sid given since it is now committed?

Other than that, I approve of the way you did this and am willing to add this function, especially since many PDF forms *are* linked to a specific Webform (nid). I'll commit it once you re-roll.

Some comments on this for whichever one of us gets to them first.

+++ b/fillpdf.admin.incundefined
@@ -194,6 +194,14 @@ function fillpdf_form_edit($form, &$form_state, $fid) {
+    '#title' => t('Default data source node ID'),

Call this "Default Node ID".

+++ b/fillpdf.admin.incundefined
@@ -194,6 +194,14 @@ function fillpdf_form_edit($form, &$form_state, $fid) {
+    '#description' => t('When filling a PDF, use this node for the data source if no node is specified in the fill URL.'),

"in the Fill PDF URL"

+++ b/fillpdf.admin.incundefined
@@ -194,6 +194,14 @@ function fillpdf_form_edit($form, &$form_state, $fid) {
+    '#maxlength' => 10,

Maybe this is overdoing it, unless Postgres and MySQL both have int(10) as a default. If that's the case, I'm fine with it.

+++ b/fillpdf.moduleundefined
@@ -256,14 +279,16 @@ function fillpdf_merge_pdf($fid, $nids = NULL, $webform_arr = NULL, $sample = NU
+        if (empty($webform['sid'])) { // user didn't specify submission-id, meaning they want most recent

Can you fix the comment here to the revised one? You can see it in the first subtracted line in this block.

+++ b/fillpdf.moduleundefined
@@ -256,14 +279,16 @@ function fillpdf_merge_pdf($fid, $nids = NULL, $webform_arr = NULL, $sample = NU
+            WHERE nid = :nid AND uid = :uid ORDER BY submitted desc', array(':nid' => $webform['nid'], ':uid' => $user->uid))->fetchField();

Can you also make this query consistent (DESC vs. desc)? Used to be like that anyway.

Tested this with a node and webform, and it looks like it works fine. Committed. When you re-roll #1404354: Fill PDF settings: Hide Configure fillpdf-service.com when not in use, I will cut a new official release.

Needs backport.

Looks good overall. Almost there, but:

+++ b/fillpdf.moduleundefined
@@ -219,14 +242,17 @@ function fillpdf_merge_pdf($fid, $nids = null, $webform_arr = null, $sample = nu
+    foreach ($webform_arr as $webform) {
+      if (!empty($webform['nid'])) {
+        if (empty($webform['sid'])) { // User did not specify submission ID, meaning they want most recent.
+          $webform['sid'] = db_query('SELECT sid FROM {webform_submissions}
+            WHERE nid = :nid AND uid = :uid ORDER BY submitted DESC', array(':nid' => $webform['nid'], ':uid' => $user->uid))->fetchField();
+        }
+        $webforms[] = array(
+          'webform' => empty($webform['node']) ? node_load($webform['nid']) : $webform['node'],
+          'submission' => webform_get_submission($webform['nid'], $webform['sid']),

I think this snuck in here. Can you re-roll without this?