This module does a few things.

1. It finds users who are being granted access via comment_acl
2. It deletes their current project subscriptions (using the 6.x-1.4 style subscriptions)
3. It subscribes them to all mails in the project (access is checked as mails go out, so they only get mails about issues they should)
4. It sends them a one-time mail notifying them of this specific issue

I based it on our standard template, but tweaked a bit to give it more of a to-do list feeling since that felt to me like it would be more likely to solicit action.

CommentFileSizeAuthor
#9 sdonotifier-email-changes-1393114-09.patch6.75 KBforestmonster
#7 sdonotifier-email-changes-1393114-07.patch3.01 KBforestmonster
#6 sdonotifier-rephrasing-1393114-06.patch6.35 KBforestmonster
#1 1393114_sdonotifier.patch4.24 KBgreggles

Comments

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Active » Needs review
StatusFileSize
new 1393114_sdonotifier.patch4.24 KB
greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

per webchick changed sdonotier_mail to sdonotifer_mail as the mail key.

dww’s picture

dww
we/he/they
commented

I'd love to cut a 6.x-1.0-alpha6 release of project_issue and upgrade s.d.o to that (with all the flag integration and new email notification goodness). Seems like a step backwards to build custom code that's working with an obsolete notification system. I'd rather just move s.d.o forward, if possible.

So, IMHO, this should be postponed until #1307536: deploy flag based notifications to allow reporters/maintainers to subscribe more easily is done...

That said, I don't want to stand in the way of scratching this itch. If you want to deploy this now and then fix it while we're doing #1307536 that also works.

Don't have time today (or probably in the next week or two) to review this. :/

Cheers,
-Derek

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

I feel the same way. Luckily the subscription related code here is pretty small so it should be pretty easy to update this when the rest of the site is updated and I'm willing to commit to do that.

@dww - do you have a sense of when the 6.x-1.0-alpha6 + deployment would happen?

dww’s picture

dww
we/he/they
commented

I replied at #1307536-4: deploy flag based notifications to allow reporters/maintainers to subscribe more easily which seemed like a better place...

Cheers,
-Derek

forestmonster’s picture

forestmonster commented
StatusFileSize
new sdonotifier-rephrasing-1393114-06.patch6.35 KB

@greggles, I found some time and tested this tonight. It works. :) I rephrased some things, check it out.

The only problem I can see is that we may be confusing folks when we give them a "view grant" to an issue and, though they are not the maintainer, they receive the "to do"-style e-mail. However an automated inclusion of the maintainer's e-mail address might not suffice, because I assume the team probably wouldn't want to be bound to only sending that tone of e-mail to the project's listed maintainer (in case we felt that someone else should really be responsible for fixing an issue).

forestmonster’s picture

forestmonster commented
StatusFileSize
new sdonotifier-email-changes-1393114-07.patch3.01 KB

Made some language changes in the e-mail, since this message will get sent out to contributors and researchers as well as maintainers.

scor’s picture

scor commented
Status: Needs review » Needs work

@forestmonster is #7 an interdiff? not sure which patch it's rolled against.

+++ b/sdonotifier/sdonotifier.module
@@ -49,17 +49,17 @@ Hello @name,
+1. If you are the maintainer, please comment on the issue acknowledging that you are aware of, and working on, the vulnerability.

that you are aware of the vulnerability and working on a fix.

forestmonster’s picture

forestmonster commented
Status: Needs work » Needs review
StatusFileSize
new sdonotifier-email-changes-1393114-09.patch6.75 KB

Yep, I accidentally diff'ed the wrong commits. Okay, thanks @scor. Made your change. Please take a look.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Needs review » Fixed

Now committed http://drupalcode.org/project/securitydrupalorg.git/commit/744bdd9 and http://drupalcode.org/project/securitydrupalorg.git/commit/221d54a

Thanks Forest, Scor and mlhess for your help.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.