Closed (fixed)
Project:
Core Library
Version:
7.x-1.0-beta10
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
3 Jan 2012 at 21:46 UTC
Updated:
23 Jan 2012 at 12:01 UTC
mediaelement module specifies
'js' => array(
// The mediaelement script detects the path to itself to call other files
// in the same location. With preprocessing this is problematic as the
// script is no longer in the same directory as its other assets. There
// is an option that can be passed into the script with its location.
// @todo Update all calls to mediaelement to pass in the assets location.
$path . '/build/mediaelement-and-player.min.js' => array('group' => JS_LIBRARY, 'preprocess' => FALSE),
),
However when I enable core_library my mediaelement items break because this library is inlined with all the other ones
Comments
Comment #1
pounardThanks for reporting.
Yes the whole goal of this module is to inline everything, it's now time to start thinking about the exceptions I guess. Media element is the first one I see that really needs to be excluded from preprocess.
Comment #2
pounardI added a new option that skips preprocessing if modules forces so; this options is enabled per default (you can find it in the library settings page).
A new version of both 7.x-1.x and 7.x-2.x branches will come out in a few minutes, update yours depending on the branch you are using.
You might experience some problems once you upgrade, don't panic, this is normal: for the bugfix to fully work you will need to go to the "Administer > Configuration > Development > Library" configuration page, and manually click the "Reset learnt files" button. I also advice you to click the "Rebuild files" button just after so it might remove some crufted files.
Once you done that, please come back and tell me if you experienced any related bug. I tested myself on my development box the MediaElement.js library now works perfectly; I hope it will on your box too (I'm quite confident it will thought).
Thanks!
EDIT: New versions are 7.x-1.0-beta11 for the 1.x branch, and 7.x-2.0-beta1 for the 2.x branch.
Comment #3
pounardOh, and thanks for allow me to discover the mediaelement module, it's really nice and working perfectly! :)
Comment #4
mzealey commentedThanks very much beta11 works fine for me here.
Mark