Hi,

When I change some settings in the backend ("Flag note form title", "Flag note help text (behind textarea)", ...), Drupal says "Flag is updated". But when I reload the page, the old settings are still visible. So settings aren't stored in database.

I'm using: flag-6.x-2.0-beta6.

I tried debugging, but I couldn't find the exact problem :-( ...

Jochen

Comments

Jochus’s picture

Jochus commented

I think you need to hook into flag-6.x-2.0-beta6: flag.inc -> line 203.

I've writte this method in flag_node.module:

function flag_note_flag_options_alter($options, $flag) {
	$options['flag_note_title'] = $flag->flag_note_title;
	$options['flag_note_fieldset'] = $flag->flag_note_fieldset;
	$options['flag_note_label'] = $flag->flag_note_label;
	$options['flag_note_help'] = $flag->flag_note_help;
	$options['flag_note_history_disabled'] = $flag->flag_note_history_disabled;
	$options['flag_note_delete_unflags'] = $flag->flag_note_delete_unflags;
	$options['flag_note_default_text'] = $flag->flag_note_default_text;
	$options['flag_note_maxlength'] = $flag->flag_note_maxlength;
	$options['flag_note_vocab'] = $flag->flag_note_vocab;
	$options['flag_note_vocab_label'] = $flag->flag_note_vocab_label;
	$options['flag_note_vocab_help'] = $flag->flag_note_vocab_help;
	$options['flag_note_hide_text'] = $flag->flag_note_hide_text;	
}

This fixes the problem. But I'm not sure this is the correct way to solve this. I don't know much about flag and flag_note ... Hope it rings a bell on your side

gunzip’s picture

gunzip commented
Status: Active » Postponed (maintainer needs more info)

couldn't reproduce the bug with flag-6.x-2.0-beta6 and flag_note-6.x-2.x-dev

may you try with a clean installation ?

Jochus’s picture

Jochus commented

Mmm ... strange ... I don't have this problem on a clean drupal-6.22 install with views-6.x-2.16, flag-6.x-2.0-beta6 and flag_note-6.x-2.x-dev ... it must be something else.

I will look further into it