media.css includes the following css, which is too generic and affects elements that have nothing to do with media, causing an inconsistant browsing experience in some cases.
a.button {
display: inline-block;
margin: 10px 5px 0 0;
}
So on pages where media.css is loaded, any link with the .button class gets the above styling. This css should be more targeted towards the elements that is supposed to effect, which presumably are some elements provided by the media module?
| Comment | File | Size | Author |
|---|---|---|---|
| #6 | css-cleanup-1393598-6.patch | 450 bytes | dgorton |
| #4 | 1393598.4-media-css-target.patch | 449 bytes | mrfelton |
| #1 | 1393598.1-media-css-target.patch | 539 bytes | mrfelton |
Comments
Comment #1
mrfelton commentedI think this resolves appropriately.
Comment #2
dave reidAssigning for review.
Comment #3
dddave commented#1502060: Clean up media.css claims to heal this wound here too.
Comment #4
mrfelton commentedMaybe, but it's against 2.x, doesn't apply against 1.x, and I don't have time to try and make make it do that. Thi patch on the other hand is much smaller, simpler and easier to re-roll to apply cleanly against 1.x. Updated version attached.
Comment #5
dave reidComment #6
dgorton commentedAt the TCDrupal Media sprint.
Per conversation, rolling vs 7.x-2.x first. Will back-port to 7.x-1.x if this passes muster.
Comment #7
dave reidSince I committed #1502060: Clean up media.css to 7.x-2.x, I think we only need to commit this to 7.x-1.x now since the 2.x patch removed all instances of a.button CSS.
Comment #8
dave reidCommitted #6 to 7.x-1.x only since it applied cleanly. Thanks!
http://drupalcode.org/project/media.git/commit/84a4a65