If the view used in the popup dialog has lots of exposed filters, or lists lots of metadata under each image, then the pager or even some view items can get cut off by the bottom of the iframe.

This is owing to the fact that lots of elements in the iframe (including the iframe) are restricted to 446px high (or some variation on it.) These are hardcoded in e.g. imagebrowser.css and .js, and are therefore difficult to override with your own themeing.

I'll attach a patch in the first comment to this ticket which exposes the magic "446" as a Drupal system variable.

CommentFileSizeAuthor
#5 1393642-imagebrowser-paging-inline.patch.1.txt316 bytesjp.stacey
#3 1393642-imagebrowser-dialog-cutoff.patch.3.txt4.31 KBjp.stacey
#2 1393642-imagebrowser-dialog-cutoff.patch.2.txt4.3 KBjp.stacey
#1 1393642-imagebrowser-dialog-cutoff.patch.1.txt4.85 KBjp.stacey

Comments

jp.stacey’s picture

jp.stacey commented
StatusFileSize
new 1393642-imagebrowser-dialog-cutoff.patch.1.txt4.85 KB

Please find attached a patch which exposes "446" as a Drupal system variable imagebrowser_height, then pipes it through to browser.tpl.php and the Drupal.settings.imagebrowser.baseheight setting.

jp.stacey’s picture

jp.stacey commented
StatusFileSize
new 1393642-imagebrowser-dialog-cutoff.patch.2.txt4.3 KB

Bah, a hunk in the patches to the JS files failed on one of those trailing/not-trailing newlines. Reattaching.

jp.stacey’s picture

jp.stacey commented
StatusFileSize
new 1393642-imagebrowser-dialog-cutoff.patch.3.txt4.31 KB

And again - Javascript casts numbers to strings during addition, so ensure Drupal.settings.imagebrowser.baseheight is numeric.

jp.stacey’s picture

jp.stacey commented

Here's a separate, one-line patch to the pager styling, which currently leaves the display of all the pager li items to the browser (so typically block display.)

jp.stacey’s picture

jp.stacey commented
StatusFileSize
new 1393642-imagebrowser-paging-inline.patch.1.txt316 bytes

Sorry, separate patch attached now.