Hi,

I've updated the URL in the file INTRO.txt and removed some weird characters at the start of system-module.po, which caused an error with msgfmt -cv.

Regards,
Tobias

CommentFileSizeAuthor
typos_0.patch1.08 KBtoddy

Comments

toddy’s picture

Status: Active » Reviewed & tested by the community
René Schwarz’s picture

Assigned: Unassigned » René Schwarz
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

I agree with your changes into INTRO.txt, but could you explain me the changes in system-module.po? IMHO there is no obvious change. Or is it only a difference with the character encoding?

toddy’s picture

Status: Postponed (maintainer needs more info) » Needs review

You're right, there's no obvious change -- but there is a change. If you view the file in a hex-editor, you'll notice that the patch removes three bytes of data right at the start of the file. The command msgfmt -cv (which checks the validity of .po files) complains about those three bytes and emits an error message. Without those bytes, the .po file can be parsed without an error.

I just saw that #139636 is about the same error -- so this is essentially a duplicate, although the patch in #139636 does not solve the parsing error for me.

Regards,
Tobias

kkaefer’s picture

Thank you for these two fixes. The second patch (system-module.po) didn't work when I downloaded the patch. It looks like this has been a low level encoding issue (Unicode BOM?) which should be fixed now.

toddy’s picture

Status: Needs review » Fixed

Yes, exactly, it has been the Unicode BOM. The error is gone now, system-module.po does no longer show a parse error.

dries’s picture

Status: Fixed » Closed (fixed)