Closed (fixed)
Project:
e-Commerce
Version:
5.x-3.x-dev
Component:
cart
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
26 Apr 2007 at 15:31 UTC
Updated:
26 Jul 2007 at 02:48 UTC
In cart.module, line 380:
drupal_set_message(t('Login or <a href="%reg-link">register</a> to continue the checkout process', array('%reg-link' => url('user/register', drupal_get_destination()))));
Uses the "%" token which causes the href value to have an "" tag wrapping it.
It should use the "!" token.
I attached a patch.
| Comment | File | Size | Author |
|---|---|---|---|
| cart-register-link-fix.patch | 783 bytes | jbjaaz |
Comments
Comment #1
jbjaaz commentedStripped out an html tag. It should read "...to have an "em" tag wrapping..."
Comment #2
brmassa commentedComment #3
gordon commentedFixed in v4
Comment #4
gordon commentedcommit http://drupal.org/cvs?commit=66799 needs to be backported to v3
Comment #5
sethcohn commentedthere is actually a second example of this a few lines down in the code...
Perhaps the entire codebase can be checked for the incorrect % (which should be !), this is far from the only case of it.
Comment #6
sethcohn commentedActually, as long as we're reviewing it... it seems the usecase here is reversed:
it's FAR MORE likely that those not logged in will need to create an account, not simply login.
Changing the location the anonymous user is sent from /user to /user/register
(and then linking to /user for the Login part of the text) makes _far_ more sense.
I've patched this for my own use, and I think it's likely to be more useful this way to others as well.
If others agree, I'll post the patch (which is otherwise pretty trivial)
Comment #7
brmassa commentedAll EC4 code checked and fixed
Comment #8
gordon commentedI have ported this already to 5.x-3.x-dev
Comment #9
(not verified) commented