Just a small c&p error

CommentFileSizeAuthor
#4 1394804.patch716 bytesdawehner
#2 1394804-undefined-variable.patch1.08 KBdawehner
#1 1394804-undefined-variable.patch1.08 KBdawehner

Comments

dawehner’s picture

dawehner
Primary language German
commented
Status: Active » Needs review
StatusFileSize
new 1394804-undefined-variable.patch1.08 KB

Here is the patch

dawehner’s picture

dawehner
Primary language German
commented
StatusFileSize
new 1394804-undefined-variable.patch1.08 KB

Classical fail

swentel’s picture

swentel commented
Status: Needs review » Needs work 
+++ b/plugins/tasks/pm_existing_pages.incundefined
@@ -167,13 +167,14 @@ function pm_existing_pages_pm_existing_pages_build_subtask($task, $task_id) {
-    'row class' => empty($page->disabled) ? 'page-manager-enabled' : 'page-manager-disabled',
+    'row class' => empty($disabled) ? 'page-manager-enabled' : 'page-manager-disabled',
     'storage' => t('In code'),
     'disabled' => variable_get('pm_existing_pages_disabled_' . $task_id, TRUE),

Maybe we can replace the variable_get in the 'disabled' key as well.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs work » Needs review
StatusFileSize
new 1394804.patch716 bytes

page_manager_get_pages() has the following code

    if (!empty($task['disabled'])) {
      $class[] = 'page-manager-disabled';
    }

So here is a patch for that.

swentel’s picture

swentel commented
Status: Needs review » Fixed

Committed and pushed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.