First a big thanks to everyone who helps make this stuff work! I'm still an amateur, but am having lots of fun trying to figure it all out.

I've set up a simple test 5.1 site with a bluemarine theme. On one page, using php input format, I've entered the sample 3 tab array code ending with print tabs_render($form);

Using Firefox, it looks pretty good, but the 1px bottom-border of the ul.primary has a gap below the unselected tabs, while in IE 7, the same 1px bottom-border of the ul.primary seems to cut through the tabs about 5 pixels above the bottom.

My CSS is good enough to probably fix it in one browser, OR the other, but I have had limited success over the past 2 days trying to get it to work in both.

As a point of reference, the Drupal Core Tabs look Perfect in both browsers. And at http://www.stilbuero.de/jquery/tabs/ it looks great in both too.

My question is, should I be printing the tabs through some other function than tabs_render() ? or should it be working fine as I have set it up? Thanks if you can help!

Comments

herb’s picture

herb commented

After some fooling around with this, it appears that the conditional stylesheet for IE is not being recognized, or being overridden by other stylesheets following it?
By copying the contents of tabs-ie.css to the end of my style.css file it seems to fix the error in IE7. (The display: inline-block; appears to be the culprit)
I'm not an expert so I don't know what the impact of this might be on other browsers, but maybe this will help someone else develop a more professional solution.

jwilde’s picture

jwilde commented

Hey Herb,

Great idea! It works perfectly - thank you. ...I've been having problems with tabs in IE for weeks. This also fixes the tabs in active search.

Kind regards,

Jim

herb’s picture

herb commented

Hi Jim,

Glad I could help,, and I'm glad that I wasn't the only one with this issue. I haven't found any unintended consequences yet, but I would feel better if the conditional stylesheet worked in the header. Wondering if I should have categorized this a a bug report instead of support request?

nedjo’s picture

nedjo
he/him/his
Primary language English
commented
Category: support » bug

Yes, a bug. Could you please check with the tabs site, http://www.stilbuero.de/jquery/tabs/, and determine if there are changes there that we need to be making? E.g., refreshing our copy of the jquery tabs library? A patch would be great, or failing that more details on what we need to change.

herb’s picture

herb commented

Hi nedjo - I'm afraid my capabilities could be characterized as those of a self taught, determined, amateur who didn't know anything about Drupal, PHP, or MySQL 6 months ago. Nevertheless, if I can figure out anything on this issue, I'll follow-up on this thread.