When the 7.x patch was applied, files were saved with DOS line endings. This can most easily be spotted via the repository viewer, note the "\r" notation in the .inc and .module files:

http://drupalcode.org/project/views_arg_context.git/commitdiff/9ff7eb5

CommentFileSizeAuthor
#5 views_arg_context-fix_line_endings-1395210-5.patch10.69 KBbartlantz
#4 views_arg_context-fix_line_endings-1395210-4.patch10.69 KBbartlantz
#2 views_arg_context-fix_line_endings-1395210-2.patch10.66 KBbartlantz

Comments

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Novice

Oh, heavens. How embarrassing. This is what I get for not testing the patch myself. :)

Tagging novice for the task of cleaning up all the silly linebreaks!

bartlantz’s picture

bartlantz commented
Assigned: Unassigned » bartlantz
Status: Active » Needs review
StatusFileSize
new views_arg_context-fix_line_endings-1395210-2.patch10.66 KB

Here's a patch that should fix this issue. The new drupal vim plugin makes those line endings stand out.
Thanks,
Bart

xjm’s picture

xjm
she/her
Primary language English
commented
Status: Needs review » Needs work

Hi @bartlantz. Thanks for the patch! There's one additional thing that needs work in the patch:

+++ b/plugins/views_plugin_argument_default_context.incundefined
@@ -1,49 +1,49 @@
\ No newline at end of file

+++ b/views_arg_context.moduleundefined
@@ -1,102 +1,102 @@
\ No newline at end of file

There does need to be a single newline at the end of the files. (Reference: http://drupal.org/coding-standards#indenting). So let's fix that as well.

bartlantz’s picture

bartlantz commented
Status: Needs work » Needs review
StatusFileSize
new views_arg_context-fix_line_endings-1395210-4.patch10.69 KB

Sounds good, here's the new patch!

bartlantz’s picture

bartlantz commented
StatusFileSize
new views_arg_context-fix_line_endings-1395210-5.patch10.69 KB

Okay, one more patch, there was extra white space on one of the lines.

valthebald’s picture

valthebald
Location Sofia
commented
Status: Needs review » Reviewed & tested by the community

After applying patch from #5, file utility reports all line endings are Unix-style.