As mentioned in the OP at #1394810: User 1 does not automatically pass the role dependency which is inconsistent with other areas of Drupal, facets that fail dependencies still execute the empty behavior plugin. The correct behavior is that the facet should not be processed, and therefore the empty facet behavior plugin should not be executed.

CommentFileSizeAuthor
#3 skip-plugins-1395224-3.patch1.33 KBcpliakas
#1 skip-plugins-1395224-1.patch870 bytescpliakas

Comments

cpliakas’s picture

cpliakas commented
Status: Active » Needs review
StatusFileSize
new skip-plugins-1395224-1.patch870 bytes

Attached patch is my first crack at the patch.

cpliakas’s picture

cpliakas commented
Status: Needs review » Needs work

I am thinking of adding a property FacetapiAdapter::failedDependencies for code readability. It is a bit confusing that unsetting the query type plugin ties into whether a dependency passed or not.

cpliakas’s picture

cpliakas commented
Status: Needs work » Needs review
StatusFileSize
new skip-plugins-1395224-3.patch1.33 KB

Attached patch adds the property. Code is now a little more transparent.

cpliakas’s picture

cpliakas commented
Status: Needs review » Fixed

Committed at http://drupalcode.org/project/facetapi.git/commit/957a1c7.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.