With the introduction of symphony components in D8, we have two different coding style standards within Drupal Core ... we should update pifr_coder.client.inc to exclude the symphony directory when performing coder reviews.

CommentFileSizeAuthor
#8 1395712-exclude-core-vendor-dir-8.patch636 bytesjthorson
#3 pifr_coder_exclude_external_files-1395712-3.patch2.19 KBjthorson
#2 pifr_coder_exclude_external_files-1395712-2.patch2.14 KBjthorson
#1 pifr_coder_exclude_external_files-1395712-1.patch2.14 KBjthorson
pifr_coder_exclude_symfony_directory.patch1.24 KBjthorson

Comments

jthorson’s picture

jthorson commented
Title: Ignore symphony directory on core Coder reviews. » Ignore externally-provided files (such as /core/includes/Symfony) during core Coder reviews.
StatusFileSize
new pifr_coder_exclude_external_files-1395712-1.patch2.14 KB

Updated patch to also exclude jquery and system.tar.inc

jthorson’s picture

jthorson commented
StatusFileSize
new pifr_coder_exclude_external_files-1395712-2.patch2.14 KB

An extra apostrophe managed to sneak into that last patch ...

jthorson’s picture

jthorson commented
StatusFileSize
new pifr_coder_exclude_external_files-1395712-3.patch2.19 KB

And a bit more log message cleanup.

jthorson’s picture

jthorson commented

Tested on local testbot, and this change brings D8 core down from 2256 to 1186 Coder assertions. :)

jthorson’s picture

jthorson commented
Status: Needs review » Fixed

Committed to 6.x-2.x (cefb55c).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jthorson’s picture

jthorson commented
Status: Closed (fixed) » Needs work

Looks like they changed the path to /core/vendor/Symphony ... :(

jthorson’s picture

jthorson commented
StatusFileSize
new 1395712-exclude-core-vendor-dir-8.patch636 bytes

Changed core/includes/symfony to core/vendor.

jthorson’s picture

jthorson commented
Status: Needs work » Needs review
jthorson’s picture

jthorson commented
Status: Needs review » Fixed

Committed to 6.x-2.x (1a8a4d5).

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.