I installed both openid selector and persistent login modules. Persistent login remembers traditional login, but doesn't remember openid login.

Comments

gapple’s picture

Category: feature » bug
gapple’s picture

I was unable to reproduce any issues with OpenID / OpenID Selector on a 6.x site.

Some helpful information would be:
- is a series:token pair being created and stored in the database on login?
- is the PL cookie sent to the user?

myostrich’s picture

I didn't debug it, and I reproduced this issue on Drupal 7.10 + openid selector. Did you try drupal 7.10?

gapple’s picture

I haven't had the opportunity to debug 7.x, and may not for a while.
Any information you can provide on the token generation or cookies would be helpful to me or anyone else when they are able to further dig into this issue. The two items I specified are also good starting points that don't require digging into the module code.

gapple’s picture

Priority: Normal » Major

It appears that when hook_user_login($edit, $account) is called, $edit only contains 'uid' and 'redirect', and not the value of the PL checkbox or any other data from the login form.

kobayashi’s picture

Issue summary: View changes

Even in 8.x-1.3, persistent logins remember traditional logins, but openid logins do not.

Is there a way to use persistent login to remember the traditional login for openid login as well?

gapple’s picture

Version: 7.x-1.x-dev » 2.x-dev
Priority: Major » Normal

Closing out 7.x issues.
Updated version since this is reportedly still an issue with 8.x releases.

akoepke’s picture

Just providing feedback that this is still an issue as OpenID Connect. As the user is redirected, the standard login form submission process is not followed. The persistent_login_user_login_form_submit submit handler is not called.

OpenID Connect does provide a hook hook_openid_connect_post_authorize which can be used to trigger code after a user has been authorised. The challenge is that the form value for the Persistent Login field is unknown.

I am not sure if there is a way to save this form value so it can be retreived later or if that would require a patch to OpenID Connect to get those values and pass them through into $context for the hooks.

gapple’s picture

Title: It doesn't keep login when using OpenID login » Integration with OpenID login
Category: Bug report » Feature request
Status: Active » Postponed

Thanks for the updated info, @akoepke.

If someone is interested in taking this issue on it looks like there's also a hook_openid_connect_pre_authorize(), but it's not clear where pre/post fit in the auth flow, and what they allow passing through in the context variables.