Hi,

here's a bug report:

I have an expandable giant menu items, which open up into Views of products - so that users can add to cart directly from there.
To achieve this I used Views, Panels, CTools, Menu-minipanels modules.

However, the "+" and "-" buttons don't work at all when appearing inside these panels. (when it's a simple view listing it works okey, but not when that View is inside a Panel)

Comments

imiksu’s picture

Priority: Critical » Normal
Status: Active » Needs work

I can re-produce your issue. However, I don't consider this being critical since it's not rendering the system unusable and the bug is valid only in certain circumstances and even then you are able to use the site normally.

This issue sounds like an JS issue, probably by qTip JS library which Menu Minipanels is based on.

I also found out that contextual filter links were not working, so probably might not be related to this module.

imiksu’s picture

Title: + and - buttons don't work when inside Panels. » + and - buttons don't work inside Menu Minipanels.
Priority: Normal » Major
damienmckenna’s picture

I've seen conflicts between Menu_MiniPanels and other modules, due to how the JS modifies the DOM. I'll have to dig into it to see what's going on.

imiksu’s picture

Title: + and - buttons don't work inside Menu Minipanels. » Commerce Extra Quantity + and - buttons don't work inside Menu Minipanels.
Project: Commerce Extra » Menu Minipanels
Component: Quantity module » Code

According to @DamienMcKenna's comment, I'll move this to Menu Minipanels since it may be related with other JS issues too.

Throw it back anytime if you see the problem is caused by Commerce Extra module.

damienmckenna’s picture

Status: Needs work » Postponed (maintainer needs more info)

Please test with the latest 7.x-1.0-rc / -dev codebase and let me know if the problem persists. Thanks.

henrijs.seso’s picture

Priority: Major » Normal
Status: Postponed (maintainer needs more info) » Active

Let's start with core, then, if problem still exists, we can move to more specific modules like Commerce Extra.

Contextual links are not working in menu minipanels in latest -dev, probably because of missing style="display: none;", working HTML on same page outside menu minipanels reads like <ul class="contextual-links" style="display: none;"></ul>.

Could it be that menu minipanels are rendered somehow outside of page render workflow?

henrijs.seso’s picture

Title: Commerce Extra Quantity + and - buttons don't work inside Menu Minipanels. » Render minipanels in normal process - contextual links and other javascript in minipanels not working
damienmckenna’s picture

I'll work on this after the stable release (7.x-1.0).

henrijs.seso’s picture

I switched from major to normal, but it was probably too soon. I don't think this kind of "known issue" would be good for stable release.

damienmckenna’s picture

Ok, I'll see what I can do to fix it.

henrijs.seso’s picture

As a quick fix maybe it is possible to render all minipanels that are associated with menu items? That would be performance penalty, but way faster solution for development and fixable with cache?

damienmckenna’s picture

Digging into it my gut feeling is that the problem is in JS, not the HTML output, but I'm still digging.

damienmckenna’s picture

Status: Active » Needs review
StatusFileSize
new3.45 KB

This seems to be a problem with how the qTip v1 library works, I'm not sure there's not much that can be done right now in terms of a general fix.

This patch re-enables the contextual menus on all popups, and replaces some of the code responsible for building the output with some slightly more normal API calls, please give it a spin and see how it works.

henrijs.seso’s picture

Patch fixed contextual links. Thank you.

@drupalina, @iMiksu How about Commerce Extra Quantity + and - buttons?

damienmckenna’s picture

Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.