Closed (fixed)
Project:
Menu Minipanels
Version:
7.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
6 Jan 2012 at 05:04 UTC
Updated:
24 Jun 2012 at 01:41 UTC
Jump to comment: Most recent file
Comments
Comment #1
imiksuI can re-produce your issue. However, I don't consider this being critical since it's not rendering the system unusable and the bug is valid only in certain circumstances and even then you are able to use the site normally.
This issue sounds like an JS issue, probably by qTip JS library which Menu Minipanels is based on.
I also found out that contextual filter links were not working, so probably might not be related to this module.
Comment #2
imiksuComment #3
damienmckennaI've seen conflicts between Menu_MiniPanels and other modules, due to how the JS modifies the DOM. I'll have to dig into it to see what's going on.
Comment #4
imiksuAccording to @DamienMcKenna's comment, I'll move this to Menu Minipanels since it may be related with other JS issues too.
Throw it back anytime if you see the problem is caused by Commerce Extra module.
Comment #5
damienmckennaPlease test with the latest 7.x-1.0-rc / -dev codebase and let me know if the problem persists. Thanks.
Comment #7
henrijs.seso commentedLet's start with core, then, if problem still exists, we can move to more specific modules like Commerce Extra.
Contextual links are not working in menu minipanels in latest -dev, probably because of missing
style="display: none;", working HTML on same page outside menu minipanels reads like<ul class="contextual-links" style="display: none;"></ul>.Could it be that menu minipanels are rendered somehow outside of page render workflow?
Comment #8
henrijs.seso commentedComment #9
damienmckennaI'll work on this after the stable release (7.x-1.0).
Comment #10
henrijs.seso commentedI switched from major to normal, but it was probably too soon. I don't think this kind of "known issue" would be good for stable release.
Comment #11
damienmckennaOk, I'll see what I can do to fix it.
Comment #12
henrijs.seso commentedAs a quick fix maybe it is possible to render all minipanels that are associated with menu items? That would be performance penalty, but way faster solution for development and fixable with cache?
Comment #13
damienmckennaDigging into it my gut feeling is that the problem is in JS, not the HTML output, but I'm still digging.
Comment #14
damienmckennaThis seems to be a problem with how the qTip v1 library works, I'm not sure there's not much that can be done right now in terms of a general fix.
This patch re-enables the contextual menus on all popups, and replaces some of the code responsible for building the output with some slightly more normal API calls, please give it a spin and see how it works.
Comment #15
henrijs.seso commentedPatch fixed contextual links. Thank you.
@drupalina, @iMiksu How about Commerce Extra Quantity + and - buttons?
Comment #16
damienmckennaCommitted.