Hi there,

I've had a slight problem with pdfview -- I was trying to disable it on all but one node type, but later found it had re-enabled itself in some cases. I think I tracked the problem down to the hook_form_alter(), which is currently using:

'#default_value' => variable_get('pdfview_'.$form['identity']['type']['#default_value'], 1)

'$form['identity']['type']['#default_value'] does not seem to reliably defined for all node types, so in some cases the form will not find the variable and hence default back to 1 again. Changing this to:

'#default_value' => variable_get('pdfview_'.$form['#node_type']->type, 1)

seems to have solved the problem.

Thanks,

Sam.

Comments

rconstantine’s picture

rconstantine commented

You should probably also change this:
if ($form_id == 'node_type_form' && isset($form['identity']['type'])) {
to this:
if ($form_id == 'node_type_form' && isset($form['#node_type']->type)) {
just for consistency.

Or am I wrong?