I'm trying to setup this module (namecheap or openregister) but i'm stuck at the very beginning.
Once I have installed the module, the setup require to download IANA database.
When I click on the button, there is "something going on" but after a few seconds the page keep asking for the same request.
The file is correctly downloadable and I tried to put it on the module root but nothing happens.

Thanks for any clue.

CommentFileSizeAuthor
#3 registrar_api-1396566.patch4.9 KBjonhattan

Comments

hadsie’s picture

hadsie commented
Category: bug » support

Hi @pedrosp,

I just tested this out again and was unable to reproduce the issue. Downloading the file directly won't work as the data is imported directly into the database. The code uses drupal_http_request() to pull the file so it's possible that your server is not configured correctly. I assume that you're not getting any error message or anything spat back at you, but the browser just keeps trying to load the page?

pedrosp’s picture

pedrosp
Location Madrid, Spain
commented

Thanks for the reply hadsie,
My server is a mercury stack (pressflow, varnish, memcached, apc...) so maybe it is proxy related, I will try to disable varnish. disabling varnish bring the same result.
There is no error message, just after hitting the button the browser start loading something but ended as a reload of the same page.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented
Status: Active » Needs review
StatusFileSize
new registrar_api-1396566.patch4.9 KB

There's a bug in the code: it doesn't show the error message when the download fails.

Attached patch fixes it and also makes the admin settings form a bit cleaner IMO.

pedrosp’s picture

pedrosp
Location Madrid, Spain
commented

Thanks @jonhattan, but I'm not able to patch against the last dev. 2011-Dec-06

It seems to change registrar_api.admin.inc but I don't see this file.
I guess there is some difference between the release and the Git container.

jonhattan’s picture

jonhattan
Primary language Spanish
Location Plasencia
commented

See here how to checkout from git and apply patches:

http://drupal.org/node/438674/git-instructions/6.x-1.x

hadsie’s picture

hadsie commented
Category: support » bug
Status: Needs review » Fixed

Thanks @jonhattan. A bit of other cleanup in here too which is great. Committed.

@pedrosp there should be a new dev tarball on the site later today that you can download. Note that this likely won't solve your problem, but at least it should give you a more descriptive error message.

Cheers!
- Scott

pedrosp’s picture

pedrosp
Location Madrid, Spain
commented

Thanks @hadsie, I am waiting for the availability of the new dev tarball that seems to take longer than expected.
I will then test again.

hadsie’s picture

hadsie commented
Category: bug » support
Status: Fixed » Active

It's probably my fault. I'm not totally familiar with the new git stuff so I think I didn't push the code properly. I've tried something else now that will hopefully work :).

ferdinand.bardamu’s picture

ferdinand.bardamu commented

Hi. I see the Dec 06 2011 version is still the latest. Any chance of another go at updating with this patch?

Thanks,

hadsie’s picture

hadsie commented

I'm unfortunately at a loss as to what to do here. I'm waiting for an answer to this #1402924: Dev tarball not updating for registrar_api. I've added another comment there.

ferdinand.bardamu’s picture

ferdinand.bardamu commented

Thanks for the effort. I was just going to manually apply the patch then came to understand what pedrosp was talking about. I'm a git virgin so am dependent on the tarballs.

hadsie’s picture

hadsie commented

Ok, the new dev tarball is up now. Figured out the issue with the release :)

pedrosp’s picture

pedrosp
Location Madrid, Spain
commented
Status: Active » Closed (fixed)

I just removed the old version and uploaded the feb, 10 tar and all worked just fine :)
Thanks !