Download & Extend
Panels » Issues

When changing pane style to "System block" the "Override title" setting can't be used to delete the pane title

Posted by jenlampton on January 7, 2012 at 9:20am
Project:Panels
Version:6.x-3.x-dev
Component:User interface
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

It seems that using the system block style, I can not get the title of my content panes to disappear.

On the pane settings form I have checked the box to "override title" and typed < none > in the box, but the title still shows.

I then went to block settings (ew!) and also configured the blocks to have their titles hidden, just incase the block style pulled the setting from block settings instead of pane settings, but the titles still show on the panes.

Is it possible to hide pane titles when using the default "system block" style? I think I remember this working in the past, perhaps a new bug.

(It looks like the "Override title" setting *does* work if all you want to do is change the title - it's just the "none" that doesn't seem to work.)

edit: it looks like the "none" does still work when using "No style".

Login or register to post comments

Comments

#1

Posted by merlinofchaos on January 7, 2012 at 5:44pm

Oh this is probably because blocks use $block->subject and panes use $block->title -- maybe if the title is empty it doesn't get moved to subject and the original title sticks or something.

#2

Posted by jenlampton on January 8, 2012 at 2:35am
Status:active» needs review

That sounds about right.

I found an

if (!empty($content->title))

Which looks like it prevents an empty title from becoming an empty subject.
Is there any harm in removing that check entirely?
AttachmentSize
remove_empty_title_check-1397076-2.patch 464 bytes

#3

Posted by merlinofchaos on January 8, 2012 at 4:39am

That might cause a fail if override title is NOT checked?

#4

Posted by Letharion on January 14, 2012 at 4:36pm
Status:needs review» needs work

#5

Posted by jenlampton on February 10, 2012 at 9:14pm
Status:needs work» needs review

- Overriding the title with text works as expected.
- Overriding the title with "none" removes the title.
- Not overriding the title lets the block subject show through.

What else should I test to get this possible error?

#6

Posted by jenlampton on February 10, 2012 at 9:13pm
Version:6.x-3.9» 6.x-3.x-dev

patch still applies to latest version of panels.

#7

Posted by jenlampton on August 2, 2012 at 11:59pm

still adding this patch to every site I deploy with panels (and that's all of them) :)

#8

Posted by jenlampton on November 15, 2012 at 9:04am

Patch stopped applying cleanly. rerolled.

AttachmentSize
panels-remove_empty_title_check-1397076-8.patch 575 bytes

#9

Posted by merlinofchaos on February 8, 2013 at 9:09pm

There's a different patch in http://drupal.org/node/1912174 for D7 (probably this one never gets seen because I have not been paying much attention to D6 lately, sadly)