Create Simpletests to verify base functionality of the module

First patch.

Base Framework (Solr disabled)

Enable module
Search index should show a notice that no solr instance is connected
SolrBaseQuery unit test
SolrFilterSubQuery unit test??
ApacheSolrDocument unit test

It seems that the SubQuery test doesn't load and when I try to execute it it is failing. Waiting on response for the status of this subQuery class. Continueing now for the Base Framework tests with Solr enabled

Setting the status on needs review so the test bot can execute all of these tests

Updating, so it does not require apachesolr.module or any db queries to run the apachesolr document unit test

+ add test that verifies we are not loading the apachesolr.index.module on every or certain page loads

Some more information

Added test to verify this apachesolr.index.module + better subquery tests

Forgot a dsm and reverted a function from private to public. Fixed now

new tests

Added interface as separate file to the patch

Updated issue summary.

Updated issue summary.

Added test to clone a search environment

I had to modify the way of the operator in the FilterQuery parser :
Now :

protected function rebuildFq() {
    $fq = array();
    foreach ($this->fields as $pos => $field) {
      $fq[] = $this->makeFilterQuery($field);
    }
    foreach ($this->subqueries as $subquery) {
      $subfq = $subquery->rebuildFq();
      if ($subfq) {
        $operator = $this->operator;
        $fq[] = "(" . implode(" $operator ", $subfq) . ")";
      }
    }
    return $fq;
  }

Before :

protected function rebuildFq() {
    $fq = array();
    foreach ($this->fields as $pos => $field) {
      $fq[] = $this->makeFilterQuery($field);
    }
    foreach ($this->subqueries as $subquery) {
      $subfq = $subquery->rebuildFq();
      if ($subfq) {
        $operator = $subquery->operator;
        $fq[] = "(" . implode(" $operator ", $subfq) . ")";
      }
    }
    return $fq;
  }

This has as a consequence that subqueries now have to define their operator in the AddFilterQuery :

$query1 = apachesolr_drupal_query('DrupalTest');
    $query2 = apachesolr_drupal_query('DrupalTest');
    $query2->addFilter('label', 'bar');
    $query3 = apachesolr_drupal_query('DrupalTest');
    $query2->addFilter('label', 'baz');
    $query1->addFilterSubQuery($query2, 'OR');
    $query2->addFilterSubQuery($query3);
    // This equals (label:bar OR (label:baz)) (URL = ?fq=(label:bar OR (label:baz)))

    // multiple filters in first query
    $query1 = apachesolr_drupal_query('DrupalTest');
    $query1->addFilter('is_uid', '10');
    $query2 = apachesolr_drupal_subquery();
    $query2->addFilter('is_uid', '1');
    $query2->addFilter('tid', '5');
    $query1->addFilterSubQuery($query2, 'OR');
    // This equals is_uid:10 (is_uid:1 OR tid:5)  (URL = ?fq=is_uid:10&fq=(is_uid:1 OR tid:5))
    

The first example is easy to make with the previous code, the second example is nearly impossible unless you use an empty base query where you add subqueries to.

Updated issue summary.

After some mysql performance problems there is some update of the testing suite. Now all the tests available should succeed. Let's cross fingers!

Strike through of clone button

Adding search pages tests

Updated issue summary.

Added a clone search page test

Updated issue summary.

Reverted the operator logic and all that came along with it. Attached is the last patch for today regarding the simpletests.

Updated issue summary.

Updated issue summary.

Committed what we have so far. Addons always welcome

Updated issue summary.

Committed all #19 to 6.x-3.x

More simpletests will go in as separate issues. Closing this one

Hmm, second thoughts, reopening

We can always add more when needed. Closing as a final thought :-)

Updated issue summary.