Modify node taxonomy terms: overwriting other taxonomy

Thanks for the reply infojunkie. Im using CCK with the Content Taxonomy field.

Here's the export for this node type:

Argh...probably too much text for a comment. Now attached as txt file.

If you open the txt file and search for 'field_engine_belts_condition' you'll see this is a taxonomy lookup field. The values for this field take a value from a vocabulary with words like good, better, best.

When using VBO to update the value of a single vocabulary, the value of other vocabularies is overwritten with empty/null values. As my screenshot shows, Im using the radio button option "Replace terms within same vocabulary." FWIW I've tried using other radio button options and they all seem to exhibit the same behavior and will overwrite "unselected" field values.

thx--let me know if you have any ideas or if I'm holding it wrong ;)

PP

I've been investigating this a bit and have a rough idea of what is happening:

There are a class of vocabularies that are associated with the custom node type...there are another set of vocabularies that are referenced by CCK Content Taxonomy fields. When performing a VBO Modify node taxonomy terms, the CCK Content Taxonomy field taxonomy terms are overwritten. Interestingly, it appears the content taxonomy action works as expected.

Looking at the taxonomy.action.inc file, it looks like the case statement at line 56 may be unsetting terms incorrectly. I have to see what terms get returned by calling taxonomy_node_get_terms($node) on one of my nodes.

thx
PP

Hm... calling taxonomy_node_get_terms($node) on one of my nodes only returns the node level terms and vocab ID's...no joy there...

OK--If I'm reading this right I think I found the culprit: in taxonomy.action.inc line 99 is a conditional for content_taxonomy fields. The test for $field['type'] == 'content_taxonomy' doesnt appear to be working for me so array $term_values is basically null, and the content_taxonomy fields are nulled out at line 111.

thoughts?

thx
PP

I'll have to rebuild some of your functionality in my node view to see what's happening. Hope to get to this later today or tonight. I do know that the correct vid's are being found here (lines 98-100):

    foreach ($type['fields'] as $field) {
      if ($field['type'] == 'content_taxonomy') {
        $vid = $field['vid'];
        print $vid . '<br>';  //debug

Out of curiosity: why even touch these content_taxonomy values if the action is only updating node taxonomy?

thx
PP

Hi again--

Thanks for debugging. $term_values is populated by $term_values = $node->taxonomy[$field['vid']] - what's the value of the right-hand side? of $node?

Im not seeing any values from $node->taxonomy[$field['vid']].

    foreach ($type['fields'] as $field) {
      if ($field['type'] == 'content_taxonomy') {
        $vid = $field['vid'];
        $term_values = $node->taxonomy[$field['vid']];
        $new_values = array();
        if (is_array($term_values)) {
          foreach ($term_values as $value) {
            $new_values[]['value'] = $value;
          }
        }
        else {
          $new_values[]['value'] = $term_values;
        }
        $node->$field['field_name'] = $new_values;
      }
    }

The action Im using is Modify node taxonomy terms--not Modify content taxonomy terms. I may not be grokking the point of this function, but the taxonomy that is associated with my content_taxonomy fields isnt related to the node. In the DB, my custom content_type_products products table references the node id, and then contains columns for the custom fields I've defined. For the content_taxonomy fields I see the vocab id.

Instead of:
$term_values = $node->taxonomy[$field['vid']];

shouldn't this be something like:
taxonomy_node_get_terms_by_vocabulary($node, $vid);

Any suggestions?

thx
PP

I've dug in to this a bit more; without some discussion about this I'm hesitant to declare this a fix. As I mentioned above, I'm not sure why the taxonomy.action.inc file is even interested with content_taxonomy field values since this plugin seems to be intended for changing node taxonomy only.

Anyways, this code will return all the content_taxonomy terms associated with my custom node type:

$type_name = is_string($node) ? $node : (is_array($node) ? $node['type'] : $node->type);
$type = content_types($type_name);
foreach ($type['fields'] as $field) {
	if($field['type'] == 'content_taxonomy')
	{
		$fieldObj = $field['field_name'];
		$customFieldName = $node->$fieldObj;
		$term =  taxonomy_get_term($customFieldName[0]['value']);
		print $term->name . '<br>';
	}
}

In the meantime, I've commented out line 111 from taxonomy.action.inc which seems to preserve the content_taxonomy terms assigned to my nodes.

Hope this helps--
PP

PS: Im marking this as critical because (at least in my case) led to loss of data.

PP