Closed (fixed)
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Reporter:
Created:
8 Jan 2012 at 17:51 UTC
Updated:
22 Jan 2012 at 22:40 UTC
Jump to comment: Most recent file
Comments
Comment #1
bfr commentedHere's a patch.
Comment #2
bfr commentedAnd the patch ;)
Comment #3
bfr commentedComment #4
dawehnerThanks! Committed to both 6x-3.x and 7.x-3.x
Comment #5
bfr commentedOk, great.
By the way, it would be nice if you commited with
git am < filename.patchso the author would actually get the credit, as described here.
Comment #6
dawehnerOH i never did because most patches don't have that.
Comment #7
bfr commentedWell, maybe you could start from this patch? :)
Note, that there is an alternative method:
git commit --author="username <[username]@[uid].no-reply.drupal.org>", so for example your patch would be commited like this:git commit --author="dereine <dereine@99340.no-reply.drupal.org>".You can use that if the patch is not "git aware". You can tell the difference by looking at the patch:
If it has "email-like header"(like my patch above), then it's formatted correctly and you can use
git am. Otherwiseyou need to use the --author(or, better, teach the patcher to properly format his/her patches).
Proper authoring is very nice way of saying "thanks", since it makes the project show on authors profile(and, of course, is the proper "git" way of doing things).
Comment #8
dawehnerWell the patch is already committed.
Sadly this adds an additional "overhead" to all patches, but yeah it's worth to do that.
Comment #9
bfr commentedEasily fixable:
Yes, proper authoring introduces some overhead but it's the right thing to do to encourage contribution.
Comment #10.0
(not verified) commentedTypo