As discussed in #1392484: Separate Storm Knowledgebase into separate project.

CommentFileSizeAuthor
#25 storm_att-1397960.patch673 byteskfritsche
#22 storm--attr-fixes.patch827 bytesjuliangb
#20 storm--sa-missed-funcs.patch2 KBjohn franklin
#18 storm--kill-sa-v11.patch104.56 KBjuliangb
#17 storm--kill-sa-v10.patch104.57 KBjuliangb
#16 storm--kill-sa-v09.patch104.59 KBjuliangb
#14 storm--kill-sa-v08.patch103.61 KBjuliangb
#12 storm--kill-sa-v07.patch103.7 KBjuliangb
#10 storm--kill-sa-v06.patch86.54 KBjuliangb
#8 storm--kill-sa-v05.patch71.42 KBjuliangb
#6 storm--kill-sa-v04.patch71.47 KBjuliangb
#4 storm--kill-sa-v03.patch68.81 KBjuliangb
#2 storm--kill-sa-v02.patch63 KBjuliangb

Comments

juliangb’s picture

juliangb commented
Assigned: Unassigned » juliangb

I'm currently working on this, and it will be the next patch I post.

juliangb’s picture

juliangb commented
Status: Active » Needs review
StatusFileSize
new storm--kill-sa-v02.patch63 KB

This probably needs more work. Posting for testing.

Status: Needs review » Needs work

The last submitted patch, storm--kill-sa-v02.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm--kill-sa-v03.patch68.81 KB

This won't solve everything - but the tests shouldn't being trying to enable the now non-existent stormattribute module...

Status: Needs review » Needs work

The last submitted patch, storm--kill-sa-v03.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm--kill-sa-v04.patch71.47 KB

Status: Needs review » Needs work

The last submitted patch, storm--kill-sa-v04.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm--kill-sa-v05.patch71.42 KB

Status: Needs review » Needs work

The last submitted patch, storm--kill-sa-v05.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm--kill-sa-v06.patch86.54 KB

Status: Needs review » Needs work

The last submitted patch, storm--kill-sa-v06.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm--kill-sa-v07.patch103.7 KB

Status: Needs review » Needs work

The last submitted patch, storm--kill-sa-v07.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm--kill-sa-v08.patch103.61 KB

Status: Needs review » Needs work

The last submitted patch, storm--kill-sa-v08.patch, failed testing.

juliangb’s picture

juliangb commented
Status: Needs work » Needs review
StatusFileSize
new storm--kill-sa-v09.patch104.59 KB
juliangb’s picture

juliangb commented
StatusFileSize
new storm--kill-sa-v10.patch104.57 KB

This corrects whitespace errors.

Also, note that this patch needs to be applied to a copy of Storm from git, rather than from the downloads - otherwise the patch will not apply.

juliangb’s picture

juliangb commented
StatusFileSize
new storm--kill-sa-v11.patch104.56 KB

This kills all remaining whitespace errors (most of which were in the code to begin with).

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

Committed.

Storm attributes are now just a function of the basic Storm module.

john franklin’s picture

john franklin commented
Status: Fixed » Needs review
StatusFileSize
new storm--sa-missed-funcs.patch2 KB

Some function calls seem to have been missed. 

modules/storm$ find . -type f -print | xargs grep stormattribute_value
./storminvoice/storminvoice_handler_field_invoice_status.inc:    return storm_icon('invoice_status_'. check_plain($status), stormattribute_value('Invoice status', $status));
./storminvoice/storminvoice.theme.inc:        'data' => storm_icon('invoice_status_'. check_plain($invoice->status), stormattribute_value('Invoice status', $invoice->status)),
./storm_handler_field_attributes_domain.inc:    $value = stormattribute_value($this->definition['domain'], $key);

The stormattribute_value function is used in three places. It was renamed storm_attribute_value().

Attached patch fixes last few spots.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

Good spot - thanks!

Committed.

juliangb’s picture

juliangb commented
Status: Fixed » Needs review
StatusFileSize
new storm--attr-fixes.patch827 bytes

This should fix a white screen error on viewing the attributes list.

juliangb’s picture

juliangb commented
Status: Needs review » Fixed

Committed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new storm_att-1397960.patch673 bytes

Found another one in stormattribute_handler_filter_attributes_domain.

Patch attached. Will commit this, if testbot agrees.

kfritsche’s picture

kfritsche
Primary language German
Location 🇩🇪🇪🇺
commented
Status: Needs review » Fixed

commited.

juliangb’s picture

juliangb commented

Committed to the D7 branch also.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.