The variable for maintenance mode got changed from Drupal 6 to Drupal 7 - it used to be site_offline, now it's maintenance_mode. Global Redirect for D7 still incorrectly references site_offline. This patch simply updates the variable name.

CommentFileSizeAuthor
#8 globalredirect-maintenance-mode-1399024-8.patch469 bytesmarkpavlitski
globalredirect.patch404 bytesolarin

Comments

Status: Needs review » Needs work

The last submitted patch, globalredirect.patch, failed testing.

olarin’s picture

olarin commented
Status: Needs work » Closed (fixed)

ah pardon me, not only did i incorrectly submit that patch, but it looks like it's already fixed in the latest dev version anyway.

nicholasthompson’s picture

nicholasthompson
Primary language English
commented
Status: Closed (fixed) » Reviewed & tested by the community

Well spotted...

This isn't fixed in dev.

Although the patch failed testing, marking this as RTBC due to its simplicity.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, globalredirect.patch, failed testing.

fleshgrinder’s picture

fleshgrinder commented
Priority: Normal » Major

I can confirm this problem, this is an important issue as you might end up with the site_offline variable set to 1 but maintenance_mode set to 0 after Drupal 7 update (yes, some people really go into maintenance mode when updating). Simply changing from site_offline to maintenance_mode does the trick.

Changed to major, pretty hardcore to debug this.

biosonic’s picture

biosonic commented

I think I run into trouble when some other module set abandoned variable site_offline.

markpavlitski’s picture

markpavlitski commented
Version: 7.x-1.4 » 7.x-1.x-dev
Status: Needs work » Reviewed & tested by the community

@Olarin Good catch! Marking back to RTBC as the patch still applies to latest 7.x-dev.

markpavlitski’s picture

markpavlitski commented
Issue summary: View changes
StatusFileSize
new globalredirect-maintenance-mode-1399024-8.patch469 bytes

This is just Olarin's patch with header corrected so it applies cleanly and passes testing.

oadaeh’s picture

oadaeh commented
Status: Reviewed & tested by the community » Needs review

Changing status to get the testbot to complete the test run.

oadaeh’s picture

oadaeh commented
Status: Needs review » Reviewed & tested by the community

I found out from @berdir in IRC:

<berdir> oadaeh: this means that the branch tests are failing
<berdir> oadaeh: it makes no sense to test your patch as long as it's already failing, so there needs to be a commit that fixes the global redirect tests, then it will execute yours

By the way, manually applying the fix corrected the problem for me, so back to RTBC.

RavindraSingh’s picture

RavindraSingh commented
Version: 7.x-1.x-dev » 7.x-1.5

Patch 8 works perfectly

https://www.drupal.org/files/issues/globalredirect-maintenance-mode-1399...

pingwin4eg’s picture

pingwin4eg
Location Zaporizhia 🇺🇦
commented
Version: 7.x-1.5 » 7.x-1.x-dev
Priority: Major » Critical

Yep. Without the patch in #8 the maintenance mode completely loses its beauty. Please commit!

I'm raising the priority because the issue is very old and the bug itself is simple enough to be commited ASAP w/o tests.

P.S.: @RavindraSingh this bug is not specific to 1.5 release, but to all 1.x branch.

jody lynn’s picture

jody lynn
she/her
Primary language English
commented

Without this patch my maintenance mode managed to get itself into a circular redirect and end up with a white screen.

beautifulmind’s picture

beautifulmind
he/him
Primary language Gujarati
Location Dubai
commented

#8 works perfectly.
Thanks @markpavlitski

Regards.

apmsooner’s picture

apmsooner commented

#8 works great for me also.

sushantpaste’s picture

sushantpaste
Primary language Marathi
Location Sawantwadi India
commented

#8 Works fine for me. Thank you guys!

BarisW’s picture

BarisW commented

Thanks for the patch. Looks good to me!

  • BarisW committed 9f612eb on 7.x-1.x authored by markpavlitski 
    Issue #1399024 by Olarin, markpavlitski, oadaeh, biosonic, Fleshgrinder...
BarisW’s picture

BarisW commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-dev

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.