I was confused by the use of ! in the form_error - turns out that it's OK because the $element['#title'] is already filtered.

It seems great to me to add a comment acknowledging this use of ! since it's not common.

CommentFileSizeAuthor
note_regarding_use_of_exclamation.patch511 bytesgreggles

Comments

bartk’s picture

bartk commented
Status: Active » Closed (fixed)

Fixed in 7.x-1.x-dev.

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented
Status: Closed (fixed) » Fixed

The fix is in http://drupalcode.org/project/term_reference_tree.git/commit/f499859

Note that when you fix something the best Status is "fixed." This leaves it visible in the queue for two weeks at which point it gets automatically closed by an automated process.

Leaving it in the queue makes it visible to people who may be looking for the same issue and helps prevent duplicate issues.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.