When including add to cart button against each item on product lists it receives neither 'add to cart' nor 'button' styling. It has a class of list-add-to-cart (not node-add-to-cart).

Another styling inconsistency which probably requires me to make theming alterations in ubercart is that
Update Cart, Checkout and shipping quote buttons are styled as 'Buttons', but the Remove button is not
(no hover change). The remove button is 'form_submit class and type 'submit'.

Also annoying is that the shopping cart View Cart and Checkout links are not buttons at all (again a theming change i expect as these are links not form submit buttons).

Comments

Jeff Burnz’s picture

Jeff Burnz commented
Version: 7.x-2.0-rc2 » 7.x-2.x-dev
Category: bug » feature
Status: Active » Postponed

Annoying? Wow, it must so annoying all this free software that never does exactly what you want...

jimboh’s picture

jimboh commented

I apologise if my wording offended you in any way, I am of course extremely grateful for all the hard (and unpaid) work put in by the developers of drupal and all the contributions.

My skills as a php/drupal developer/programmer are not good enough yet for me to be providing full modules, but I do my best to contribute as much as I can by taking the time to report all things I find that are either bugs or would improve the user experience. I also, in most cases attempt to locate the sources of the bugs in code, where I am able in order to assist the maintainer. I have actually also submitted contributions on the ubercart site where I think what I have done may benefit others.

My comments were merely that AT Commerce says it is Ubercart styled and there was elements I had found that were not.

jimboh’s picture

jimboh commented
Category: feature » support
Status: Postponed » Active

I cant understand why the buttons on my site have colour schemes that dont mattch the settings for buttons in the theme. Changing the colours of the buttons has no effect on the site buttons. Am i correct in assuming that colours chosen for color top and color bottom should be applied to input items of type submit? I see that the colors.css file and the copy of the colors.css at files/color/myfoottheme/colors.css have the colour settings for [input type='submit'] but these colours arent the colours I have set in myfoottheme. I can change colours of other settings eg header top and header bottom and cart button top/bottom and see the desired effects. But not buttons.

asotthewes’s picture

asotthewes commented
Version: 7.x-2.x-dev » 7.x-2.0-rc2

It's in

sites/default/files/color/at-commerce###/colors.css
line 225

form.commerce-add-to-cart input,
.add-to-cart #edit-actions input,
input#edit-checkout,
input#edit-continue {
  border: 1px solid #ffffff;
  color: #ffffff;
  background-color: #ffffff;
  background-image: -webkit-gradient(linear, 0% 0%, 0% 100%, from(#ffffff), to(#ffffff));
  background-image: -moz-linear-gradient(-90deg, #ffffff, #ffffff);
  background-image: linear-gradient(-90deg, #ffffff, #ffffff);
  -ms-filter: "progid:dXImageTransform.Microsoft.gradient(GradientType=0,startcolorstr='#ffffff', endcolorstr='#ffffff')";
  filter: progid:dXImageTransform.Microsoft.gradient(enabled='true',startcolorstr=#ffffff,endcolorstr=#ffffff,GradientType=0);
}
Jeff Burnz’s picture

Jeff Burnz commented

Do you have the site online so I can look?

Are you saying we only need to add "list-add-to-cart" class?

The cart buttons are different style to normal buttons (at least they are meant to be...). I'll dig around and take a look, should be easy to fix.

asotthewes’s picture

asotthewes commented

It's a bit weirder, the buttons change when I change the header colors (the site is online, www.deoranjesite.nl)

Jeff Burnz’s picture

Jeff Burnz commented
Title: Ubercart add to cart in product list not receiving correct add to cart styling » Add correct selectors for UC cart button and check colors are unique
Version: 7.x-2.0-rc2 » 7.x-2.x-dev
Assigned: Unassigned » Jeff Burnz
Category: support » bug

OK, I see the issue, I have used a crappy selector, should be using

.node-add-to-cart
.list-add-to-cart

Buttons changing when you change header colors? Hmmm, it is possible, probably a mistake in the color css file. I will look at that also.

Jeff Burnz’s picture

Jeff Burnz commented
Status: Active » Fixed

Fixed, will commit shortly.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

jimboh’s picture

jimboh commented
Status: Closed (fixed) » Active

Has this been fixed? I just installed the 7.x-2.0-rc3 version and then the latest (18thfeb) dev version and I am still seeing the same issues...
ie that list.add.cart classes do not receive the add to cart styling and all other buttons are receiving the colour styling set for headers and ignoring the styling set for buttons.

#4 Thanks but I had located the style in colors.css. I meant where in code is the style (set in the theme colors section) applied to the class. I am using a custom footheme. Is the colors.css updated dynamically when you make changes to the theme in 'appearance'?

Jeff Burnz’s picture

Jeff Burnz commented

OK, I will check again, its possible a regression took place at some stage. No, colors are not updated dynamically unless you have never changed the colors and are still running the default color scheme, if you have changed anything at any point (even if you are now running the default scheme after having tried some others) you need to save the theme settings again so the new colors are written to the generated color.css file.

jimboh’s picture

jimboh commented

Thanks for the update, I can confirm that if I change the header bottom color, the input[type='submit'] border-bottom-color is changed in my default/files/color/foot-custom####/custom.css file.

Jeff Burnz’s picture

Jeff Burnz commented

I can confirm that if I change the header bottom color, the input[type='submit'] border-bottom-color is changed in my default/files/color/foot-custom####/custom.css file

What color scheme are you using?

jimboh’s picture

jimboh commented

I am using custom scheme

jimboh’s picture

jimboh commented

Just copied color directory from latest at_commerce version to footheme starter theme and that fixed it.