I had a gmap working inside of a dialog popup on first popup. If i closed the popup window and reopened it the map would explode because it was colliding with it's previous twin. Shouldn't dialog detach elements inside of it when it closes?

CommentFileSizeAuthor
#1 dialog-detach-closing-elements-1399256-1.patch584 bytessmithmilner

Comments

smithmilner’s picture

smithmilner commented
StatusFileSize
new dialog-detach-closing-elements-1399256-1.patch584 bytes

First shot in the dark at hooking into the dialog closing.

smithmilner’s picture

smithmilner commented
Status: Active » Needs review
robloach’s picture

robloach
he/him
commented
Status: Needs review » Fixed

Thanks! http://drupalcode.org/project/dialog.git/commit/2ff76c6

jantimon’s picture

jantimon commented

Is there any use-case where a closed dialog is reopened by javascript?
Otherwise it would be smart to unbind all dialog bindings and remove the html:

$(this).dialog('destroy').remove();

"Remove the dialog functionality completely. This will return the element back to its pre-init state."

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.