Allow multivalue attributes to create a token(s) to represent the multiple values

Yes you are correct, and patches are welcome.

Unfortunately we'll need to rig it so that the user can select how they want multiple token values dealt with. For example, an LDAP server might respond with several e-mail addresses and we wouldn't want to assign a ", "-concatenated version to the user's email field.

When I last looked at this almost a year ago the Token module was in the process of adding some array capabilities... I wonder if that has since been finalized.

I think that sounds reasonable.

I think the array token is provided by the token module, which isn't set as a requirement for this module.

The tests in #8 pass locally on my computer with the token module installed.

Is it worth making token a hard dependency? Alternatively we could fall back on the previous processing style if token is not available, but this might lead to weird errors. We'll need to include a few new tests for this.

#8: 1399304-array-tokens-8.patch queued for re-testing.

So I added a dummy test module to CAS Attributes to force qa.drupal.org to download token module... let's see if this works. I don't know how the list of project dependencies gets refreshed...

Fourteenth time is the charm?

Even though I'm sure it works, now I'd like to see a test written to verify the new array functionality. :0

Thanks for doing the leg work on this!

I'm attaching a patch which would make #1400466: Combine cas attributes roles module easier to implement, but I'm pretty unhappy with it.

What it does is add a "raw_array" option, which the cas attribute token system checks and then returns an array instead of a flattened array. The problem is that this feature would be unique to the cas attribute tokens, which would greatly limit it's overall applicability.

In fact, it'd probably be easier to just parse the $text with token_scan, and dig the replacements out of cas_phpcas_attributes() yourself!

So consider this patch dead in the water. The patch in the previous comment is much more to my liking.

I think that we should go back to the normal way of token handling where [cas:attribute:xxxx] returns a comma separated value of all the array values. Then we add an update hook to replace all [cas:attribute:xxxx] to [cas:attribute:xxxx:first]

Then it has array handling so no data is lost.

I'm on board with that. The only thing I'm nervous about is introducing the Token dependency, which I'm not sure how well Drupal will handle during a module update.

I've split the new token requirement into #1475384: Require Token module, so we can focus on the best technological solution here.

#19: 1399304-d7-3.patch queued for re-testing.

This is a re-roll of the patch in #19. Hasn't yet addressed comment in #21.

And here's a version that adds the changes suggested in #21. I think this is good to go but I'd like to have somebody else verify that the update function worked OK for them before I commit it.

Whoops, can't expect that update hook to catch the tokens in the tests. (Well, I suppose I could have written it to do so, but manually amending the tests is probably easier.)

If memberOf is an array, what does the token [cas:attribute:memberOf] return after this patch? If I'm reading it correctly, I think it does [cas:attribute:memberOf:join] which is probably a good idea (but a slight change from the past). We'll just need to highlight this in the release notes.

That is correct, the default assumption is now "join" rather than "first". As suggested in comment #21, the update included in this patch changes all cas attribute tokens in the existing relationships of the form [cas:attribute:memberOf] to [cas:attribute:memberOf:first] so that existing behaviour on old installations is not affected. Yes, we'll definitely want to make a clear indication in the release notes. I've tested the update hook myself but would like somebody else to test it too before I commit this, just for paranoia's sake.

Hm, after further testing this patch seems to be causing problems on my test installation, even though the Drupal Tests passed. Need to investigate further.

nevermind, the issues were on my end. re-rolling the patch anyway to make sure it applies to latest version of repo and still passes testbot before committing.

went ahead and pushed to 7.x-1.x.

memberOf still returns only the first result for me. I am using CAS, LDAP, and CAS Attributes. When I look at the LDAP tokens that are available, it returns [cas:ldap:memberOf] with only the first value, but there are many more. If I test an LDAP Server configuration through the LDAP module, I see many memberOf tokens like [memberof:0], [memberof:1], etc. Am I missing something? Thanks.

Oops, it looks like this only applies to [cas:attributes:memberof], not [cas:ldap:memberof].

Resetting status as I've opened #2044351 with my question.