Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
javascript
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
10 Jan 2012 at 08:29 UTC
Updated:
29 Jul 2014 at 20:18 UTC
Jump to comment: Most recent
similar issues:
#1387040: Bug in states.js when minified
#1386976: Bug in drupal.js when minified
#1387002: Bug in overlay-parent.js when minified
(I thought those are wrongly reported. It isn't buggies but code improves.)
| Comment | File | Size | Author |
|---|---|---|---|
| js_semicolon.patch | 1.54 KB | droplet |
Comments
Comment #1
patrickd commentedLooks good, could be applied successfully, I think there is not much to discuss about.
Comment #2
sunThis entire file shouldn't be indented in the first place. Let's open a follow-up issue for that.
This shouldn't be a local function in the first place. Let's open a follow-up issue for that.
Comment #3
droplet commentedquick patches,
#1, #1420048: fix menu* JS indention
#2, #1420056: moving shortcut local var
(im going out, leave me message. I will check when back. Thanks all reviews.)
Comment #4
dries commentedCommitted to 8.x and backported to 7.x. Thanks.