Closed (fixed)
Project:
Domain Meta Tags
Version:
6.x-1.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Feature request
Assigned:
Reporter:
Created:
10 Jan 2012 at 14:34 UTC
Updated:
7 May 2014 at 13:30 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
nonsieNot at the moment as Metatag is completely different from Nodewords. Should an opportunity present, I'd love to do it and/or maintain it. There is currently no upgrade path for Metatag from Nodewords (D6). I'm going to wait until there is one before proceeding.
As always - patches are welcome though.
Comment #2
damienmckennaComment #3
netikseo commentedAny updates? It's very important to have different front page metatags on each subdomain...
Thanks!
Comment #4
damienmckennaNothing current, just need time to get to it or a project that needs it. If anyone else happens to have some time we'd greatly appreciate patches :)
Comment #5
summit commentedHi,
Would love to see Meta Tags support Domain Access module.
My use case is being able to have different domain tokens like terms, nodes to be inserted in the domain meta tags so that the meta tags show also that you are on a different domain with different title, key words and description.
May be through the entity way? Something like http://drupal.org/node/1688286 but than not for languages, but for domains?
Greetings, Martijn
Comment #6
bcobin commentedSee http://drupal.org/node/1788292 - in short, @agentrickard states that:
Perhaps someone with coding skills would want to take a crack at it...
Comment #7
nonsieThe code required to get it working for DA in D7 is not that much different from D6. What has changed and will be time consuming is Nodewords/Metatag part.
Comment #8
damienmckennaSomeone has already built this and I'm discussing with them to merge their work into this module. More later.
Comment #9
artofeclipse commentedSorry for the delay, I'm currently working on D7 port for this project and merging domains metatag and it will be in the next couple week.
Comment #10
summit commentedHI Ma'moun, great to hear.
Looking forward to it! Would be great before Christmas :)
greetings, Martijn
Comment #11
remkovdz commentedI need to set different meta descriptions (each for a domain) per node. Is that what this module (when ported) intents to do or will it only work for the frontpage?
Comment #12
damienmckennaClosed a duplicate: #1956314: "Localize" metatags based on Domain Access
Comment #13
remkovdz commentedHi, I'm still curious if, when this module is ported to D7, this will only work for the front page? Or will it for example be possible to set default Meta Tags for each domain?
My use case:
- 3 domains
- Same products on all domains, but with very different target audience
- Audiences: B2B, B2C informational, B2C transactional (webshop)
For instance, I'd like the B2B Meta Tags always to end with something like "Contact us for more information", and the B2C webshop with something like "Buy now".
Will this be possible?
Comment #14
damienmckenna@artofeclipse: Any update on your progress?
Comment #15
artofeclipse commented@DamienMcKenna I'm working on it right now, sorry for the delay on this issue, I will push my code to 7.x branch and hopefully we will get it working soon.
Comment #16
damienmckenna@artofeclipse: no worries :) Thanks for the update!
Comment #17
artofeclipse commented@DamienMcKenna I pushed my changes to the branch please review my code and test it, if there is any change I must do just inform me about it :) and if you have time maybe we can have a skype call to discuss the changes/new feature or a better implementation.
Comment #18
remkovdz commentedCan I test D7 version somewhere? And also, please have a look at #13, thanks a lot.
Comment #19
nonsie@artofeclipse - I took a look at the code you committed. Attached is a patch to make it better.
Some notes:
- run the code through Coder, it gives you the obvious missing pieces
- I don't understand the need for ksort in _domains_metatag_get_active_domains as the keys are incremental to begin with. The domains are ordered by weight due to domain_id_list() which is called by domain_domains().
- you should never use a variable inside of t() function, use a placeholder instead (see http://api.drupal.org/api/drupal/includes%21bootstrap.inc/function/t/7)
- don't create variables you are not going to use
@DamienMcKenna - anything from Metatag that should be revised?
Comment #20
nonsiePatch attach fail. This is the right one.
Comment #21
artofeclipse commented@nonsie, Thanks for the patch and your comments, patch applied and pushed to the codebase
Comment #22
netsensei commentedIs it possible to create a D7 release of the dev branch? Or potentially even a D7 stable release if this is ready to go?
Thx!
Comment #23
yogeshchaugule8 commentedHi Nonsie,
Can we please add Drupal 7 Module link on this module page? So its easy to find D7 module.
Comment #24
damienmckennaI've released the dev version, lets work from there to finish off the module.