like the project page states,there is no mail wrapper for drupal 7..so using another mail_system renders this module useless when modules that provide own mail_systems are used, unless those modules explicitly save the data into the maillog table, (replicating the code in maillog module).

So,instead of replicating the code,maillog should provide a function to log the mail,and maybe one to display the mail using dpm

CommentFileSizeAuthor
#6 maillog-provide_faster_integration_with_maillog-1399752-6-7.x-1.x-dev.patch1.81 KBalex.bukach
#4 1399752-provide_faster_integration_with_maillog-4.patch4.29 KBjonathan_hunt
#2 1399752-provide_faster_integration_with_maillog-1.patch3.13 KBParisLiakos

Comments

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Active » Closed (duplicate)

This is initiated with mailsystem.
http://drupal.org/project/mailsystem

There are identical issues that request this kind of stack. Maillog should only implement those APIs (that are missing in core) while a tool like mailsystem should introduce such APIs.

ParisLiakos’s picture

ParisLiakos commented
Assigned: Unassigned » ParisLiakos
Status: Closed (duplicate) » Needs review
StatusFileSize
new 1399752-provide_faster_integration_with_maillog-1.patch3.13 KB
ParisLiakos’s picture

ParisLiakos commented

Sorry,for changing the status,crossposting.
i know about mailsystem..but till then,i was thinking about abstracting the code to those two reusable functions,so other modules can log their emails easier,instead of duplicating the code.

i think i didnt explain well in the issue summary,you will know what i mean once you check the patch.

jonathan_hunt’s picture

jonathan_hunt commented
StatusFileSize
new 1399752-provide_faster_integration_with_maillog-4.patch4.29 KB

An updated patch that includes more recent logic in maillog_log(). It is good to add additional structure to the module and allow the functionality to be called from other modules.

ParisLiakos’s picture

ParisLiakos commented
Assigned: ParisLiakos » Unassigned
alex.bukach’s picture

alex.bukach commented
Title: Provide a faster way for maillog integration by other contrib modules » Maillog integration with other contrib modules
Issue summary: View changes
StatusFileSize
new maillog-provide_faster_integration_with_maillog-1399752-6-7.x-1.x-dev.patch1.81 KB

I propose another way that uses a kind of chaining (its seems something like that was planned to implement or was left from 6.x version). This way, in mailsystem settings one needs to select MailLogSystem class where appropriate, and in MailLog settings one needs to select another MailSystemInterface class which will be used by MailLog to send format and mails.

alex.bukach’s picture

alex.bukach commented
Status: Needs review » Active
alex.bukach’s picture

alex.bukach commented
Status: Active » Needs review

The last submitted patch, 2: 1399752-provide_faster_integration_with_maillog-1.patch, failed testing.

The last submitted patch, 4: 1399752-provide_faster_integration_with_maillog-4.patch, failed testing.

das-peter’s picture

das-peter commented
Status: Needs review » Reviewed & tested by the community

I'd say #6 should go in. Patch is pretty straight forward and fixes the current code.
Maybe the issue can be "re-opened" later-on to evaluate further what to do with other contrib modules.

neochief’s picture

neochief commented

+1 for this change.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Version: 7.x-1.x-dev » 8.x-1.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks, committed. Let's see what we can do about this in 8.x.

  • Berdir committed e8ed322 on 7.x-1.x authored by Alex Bukach 
    Issue #1399752 by Alex Bukach, jonathan_hunt, ParisLiakos: Maillog...
alex.bukach’s picture

alex.bukach commented

Berdir, though the patch is committed, it's not in the 7.x-1.x-dev snapshot which is of July 17 (while commit is of July 18). Can it be fixed?

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

Not sure, commit looks fine to me. I can't trigger a dev release manually.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented

I created an alpha release and it is correct, so I guess something went wrong with the timing here. It's in the alpha and I expect it will be correct in the dev the next time something is committed.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented
Version: 8.x-1.x-dev » 7.x-1.x-dev
Status: Patch (to be ported) » Fixed

Let's do a separate issue for D8.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.