Closed (fixed)
Project:
@font-your-face
Version:
7.x-2.x-dev
Component:
User interface
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
10 Jan 2012 at 15:51 UTC
Updated:
1 Feb 2012 at 05:20 UTC
Jump to comment: Most recent file
Comments
Comment #1
whthat commentedThis is also the case for the 7.x-2.0 version. Although you can browse for the font to get to the full settings page and add more than 128 characters. This takes a bit of extra time to complete. Another option may be just allowing access to the full font settings page from the main Font-Your-Face view.
Comment #2
sreynen commentedThis will need to be fixed in the dev version first. This should be a very simple fix, a great opportunity for a new contributor to get some experience making a patch. It's also a pretty rare use case and there's already a work-around, so I'm going to wait a bit on this in hopes that it can be a learning experience for someone.
Comment #3
whthat commentedI made a patch to fix the maxlength, the 128 value seems to be an inherited value. I hard coded a maxlength of 1024 into this fix. Hope the patch is formatted correctly (Git first timer).
Comment #4
sreynen commentedLooks good, thanks. I'll try to get it committed soon.
Comment #5
sreynen commentedI'm going to change this to "needs review" just to see what the testbot says, more to make sure the tests still work than to test the patch.
Comment #6
sreynen commentedCommitted.