Updates in init() like #1367304: Using OR in filters breaks contextual filters cause changes to the view that aren't kept unless it is saved, yet the save button is hidden by default.

CommentFileSizeAuthor
#4 views-1400240-4.patch2.28 KBtim.plunkett
#1 views-1400240-1.patch468 bytestim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
StatusFileSize
new views-1400240-1.patch468 bytes

Here's an example for the issue in the OP.

dawehner’s picture

dawehner
Primary language German
commented

Let's mark that one as duplicate #1400230: Decide whether the view should be marked as changed if any kind of converting happened

dawehner’s picture

dawehner
Primary language German
commented

If +1 would be still allowed i would put an +1 for this approach.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Views init() methods that update the view should notify the user » Changes made in views_plugin_display::init() that update the view should notify the user
Status: Active » Needs review
StatusFileSize
new views-1400240-4.patch2.28 KB

After adding a couple $this->view->changed = TRUE; lines into the code, I decided to try this approach, since it's easier to understand what is going on if you read the function top to bottom, and just as easy to figure it out when just jumping in.

Changing the title because I can't think of other places this needs to be done and isn't.

dawehner’s picture

dawehner
Primary language German
commented
Version: 7.x-3.x-dev » 6.x-3.x-dev
Status: Needs review » Patch (to be ported)

This patch looks fine so let's get that in.

mustanggb’s picture

mustanggb commented
Issue summary: View changes
Status: Patch (to be ported) » Closed (won't fix)