| Project: | Calendar |
| Version: | 7.x-3.x-dev |
| Component: | MultiDay |
| Category: | bug report |
| Priority: | minor |
| Assigned: | Unassigned |
| Status: | fixed |
Issue Summary
The module css provides a custom clearfix:after in line 834 of the calendar_multiday.css, which makes all views sadly clear, and what can make some css grids collab when the .view-content div is wrapping a grid div, which is classified as column instead of a row. Since .view-content css class is used by all rendered views I would like to suggest the Drupal class .clearfix as class attribute, which is mostly fine.
To reproduce: If you use a css grid or anything what makes your blocks and regions flexible for responsive web design you may or may not come to the point, where some views regions suddently start to get displayed as block instead of an inline region to each other. In the worsed case you sot there for 2 hours like me, to find out, that the views css which you alreaday know deeply has got hijacked from calendar css to make the .view-content div using its own clearfix. zzzong ... Of course, you can reset that again in your own css, but it depends on weight and use case if this will work in every situation.
Patch follows next hour ...
Comments
#1
hm .. since there seems to be no point where we could inject another clearfix class without any risk to loose dynamic in other use cases, I simply removed/escaped the css part clearing the .view-content div container in the multiday css. It seems like it was in there only for making sure, that it is really cleared, but makes no sense to be provided here anyway. There are no obvious floats inside. If somebody wants to clear a view, he/she can just go into the views UI and put a clearfix where it is needed anyway. But how it was here before (hard coded inside the tpl css) we create more problems than we solve.
Pretty less than a patch, but maybe easier to handle than to copy paste. So here it is ...
#2
please test the patch by using calendar views and tab thru' all month, week, day views and report if there is anything floating accidently, what should rather be cleared. I did that test already on IE, FF, and Chrome and can report that nothing floats wrong so far, but I would like to have one two others reporting the same before we set it to RTBC.
#3
I don't see any problems removing this. It is probably a left-over from some long-ago css. We don't comment code out, we want to just remove it.
#4
http://drupalcode.org/project/calendar.git/commit/4d9b735