Project:Node style
Version:6.x-1.1-alpha2
Component:Code
Category:feature request
Priority:normal
Assigned:Zen
Status:closed (fixed)

Issue Summary

http://drupal.org/cvs?commit=65517

now we can circumvent this variables workarounds... :-) currently untested...

Comments

#1

Title:theme_variables_HOOK has been committed!» Update module for D6
Status:active» postponed

Thanks :) I saw that too. We'll wait till an RC comes out before updating the module.

Cheers,
-K

#2

Status:postponed» active

Time to start... :-)

#3

Yeah, it's a good and seemingly fairly unique module. Be good to have in D6.

#4

In the meantime I learned a bit more about Drupal and creating .tpl.php files for my content types and using drupal_add_css() in those files actually fulfills my needs fine. Just posting this in case someone like me wants to launch on D6 and needs this functionality.

#5

Would great to use it in D6!!!!

Thanks for your effort!!!!

#6

does your post mean there is a (development-) version available for D6 ?

#7

I need this module ported onto D6 as well.

I intend to chip in; I can contribute via PayPal.

#8

subs

#9

Status:active» needs review

Here is a preliminary version of the module for Drupal 6. It works for me, after a day or so of testing. Let me know if it works for you.

I have attached it both as a patch (a messy one, though) and as a .tar.gz. Note that it is a direct port and does not leverage the Drupal 6 theming improvements. I offer this as a base for others to build on.

AttachmentSize
node_style_6.x-1.0.tar_.gz 14.56 KB
node_style_d6.patch 21.25 KB

#10

Status:needs review» needs work

1. Do not t'ify schema title/descriptions.
2. We should really implement the new theming hook... this makes the module much more usable and easier to implement as before.

#11

Thanks for the review. I didn't know you weren't supposed to put t() around schema title/descriptions - the deadwood module did that for me.

I've only been working on Drupal 6 modules for a few weeks now, and confess that I still don't know much about the new theming system. Any help you could offer on implementing the new theming hook would be greatly appreciated.

Attached is a patch to correct the .install file. I have also added in descriptions for all the fields.

AttachmentSize
node_style-install-d6-no-t.patch 1.63 KB

#12

If I remember correctly you need to add the below hook to the module and alter/override the variables as needed... so no more a duplicate function name, no errors... maybe some more hooks are required - not sure. Please always post complete patches.

function node_style_preprocess_page(&$vars) {

}

#13

i have install the latest drupal 6.12 with the node_style_6.x-1.0.tar and the node style does not work, i just install node_style_6.x-1.0.tar and apply this patch node_style-install-d6-no-t.patch

#14

I haven't upgraded to Drupal 6.12 - I'll check on that. I think that unless you have a lot of legacy data in the Node Style module, though, you should probably check out ThemeKey. It's a D6 module that I think does all that this module did and more. So I probably won't work more on this project.

#15

Version:master» 6.x-1.1-alpha2
Assigned to:Anonymous» Zen
Status:needs work» fixed

I've ported the module to D6. It's an initial port and I've created an ALPHA release for it. Please test and file (separate) issues accordingly.

-K

#16

Status:fixed» closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

nobody click here